Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Received-SPF: neutral (hermes.apache.org: local policy)
Message-ID: <41E32C04.4030608@javactivity.org>
Date: Mon, 10 Jan 2005 19:29:40 -0600
From: Steve Cohen <scohen@javactivity.org>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)
MIME-Version: 1.0
To: Jakarta Commons Developers List <commons-dev@jakarta.apache.org>
Subject: [net] Re: [GUMP@brutus]: Project commons-net (in module
 jakarta-commons)
 failed
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Has anyone had a chance to look at this?

The root of the problem seems to be that the test assumes that it should 
always be able to open three sockets at ports 3333, 3334, and 3335, 
which it tries to do in the initalizing method openConnections().  On 
Gump, this fails, presumably because one of these sockets is always in use.

Unless there is something special about these three ports, it would seem 
that this test is flawed.  I have seen similar problems when JUnit tests 
are applied to methods that access databases.  Someone might write a 
test that an "insert" statement works correctly, but forgets about 
unique constraints or primary keys.  Unless the database is in a known 
state, such tests are not reliable and will fail if the conditions are 
not right.

Is that what is going on here?  It seems to be so.  Nothing of the real 
functionality being tested seems to depend on any specific port.  These 
tests are failing in the initialization, not in the executing of the 
tests themselves.

It would seem that this initializing method would be better written to 
try a bunch of port numbers in succession until three have successfully 
opened and then test these sockets.

Would it be worth doing this, or are there just some places where this 
test cannot be run, because of permissions, etc.  ?


Stefan Bodewig wrote:
> To whom it may engage...
>         
> This is an automated request, but not an unsolicited one. For 
> more information please visit http://gump.apache.org/nagged.html, 
> and/or contact the folk at general@gump.apache.org.
> 
> Project commons-net has an issue affecting its community integration.
> This issue affects 9 projects,
>  and has been outstanding for 73 runs.
> The current state of this project is 'Failed', with reason 'Build Failed'.
> For reference only, the following projects are affected by this:
>     - commons-net :  Commons Net
>     - eve :  Eve Directory Server
>     - eve-core :  Eve Directory Server
>     - eve-protocol :  Eve Directory Server
>     - james-server :  James Server
>     - kerberos :  Apache Kerberos Server
>     - kerberos-protocol :  Apache Kerberos Server
>     - seda :  An internet protocol server framework
>     - smartfrog-components :  Smartfrog: Application Deployment from HP Laboratories
> 
> 
> Full details are available at:
>     http://brutus.apache.org/gump/public/jakarta-commons/commons-net/index.html
> 
> That said, some information snippets are provided here.
> 
> The following annotations (debug/informational/warning/error messages) were provided:
>  -DEBUG- Sole output [commons-net-10012005.jar] identifier set to project name
>  -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/net/target/classes]
>  -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/net/target/test-classes]
>  -INFO- Failed with reason build failed
>  -INFO- Failed to extract fallback artifacts from Gump Repository
> 
> 
> 
> The following work was performed:
> http://brutus.apache.org/gump/public/jakarta-commons/commons-net/gump_work/build_jakarta-commons_commons-net.html
> Work Name: build_jakarta-commons_commons-net (Type: Build)
> Work ended in a state of : Failed
> Elapsed: 29 secs
> Command Line: java -Djava.awt.headless=true -Dbuild.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/home/gump/workspaces2/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-net-10012005 dist 
> [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/net]
> CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/net/target/classes:/usr/local/gump/public/workspace/jakarta-commons/net/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/ant/bootstrap/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/bootstrap/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-oro/jakarta-oro-10012005.jar
> ---------------------------------------------
>     [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.377 sec
>     [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.377 sec
> 
>     [junit] Testcase: testConstructors took 0.009 sec
>     [junit] Running org.apache.commons.net.telnet.SimpleOptionHandlerTest
>     [junit] Testsuite: org.apache.commons.net.telnet.SimpleOptionHandlerTest
>     [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.389 sec
>     [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.389 sec
> 
>     [junit] Testcase: testConstructors took 0.008 sec
>     [junit] Testcase: testStartSubnegotiation took 0.001 sec
>     [junit] Testcase: testAnswerSubnegotiation took 0 sec
>     [junit] Testcase: testWill took 0 sec
>     [junit] Testcase: testDo took 0.001 sec
>     [junit] Running org.apache.commons.net.telnet.SuppressGAOptionHandlerTest
>     [junit] Testsuite: org.apache.commons.net.telnet.SuppressGAOptionHandlerTest
>     [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.419 sec
>     [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.419 sec
> 
>     [junit] Testcase: testConstructors took 0.011 sec
>     [junit] Testcase: testStartSubnegotiation took 0 sec
>     [junit] Testcase: testAnswerSubnegotiation took 0 sec
>     [junit] Testcase: testWill took 0.002 sec
>     [junit] Testcase: testDo took 0 sec
>     [junit] Running org.apache.commons.net.telnet.TelnetClientTest
>     [junit] Testsuite: org.apache.commons.net.telnet.TelnetClientTest
>     [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0.427 sec
>     [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0.427 sec
> 
>     [junit] Testcase: testInitial took 0.037 sec
>     [junit] 	Caused an ERROR
>     [junit] Address already in use
>     [junit] java.net.BindException: Address already in use
>     [junit] 	at java.net.PlainSocketImpl.socketBind(Native Method)
>     [junit] 	at java.net.PlainSocketImpl.bind(PlainSocketImpl.java:331)
>     [junit] 	at java.net.ServerSocket.bind(ServerSocket.java:318)
>     [junit] 	at java.net.ServerSocket.<init>(ServerSocket.java:185)
>     [junit] 	at java.net.ServerSocket.<init>(ServerSocket.java:97)
>     [junit] 	at org.apache.commons.net.telnet.TelnetTestSimpleServer.<init>(TelnetTestSimpleServer.java:43)
>     [junit] 	at org.apache.commons.net.telnet.TelnetClientTest.openConnections(TelnetClientTest.java:56)
>     [junit] 	at org.apache.commons.net.telnet.TelnetClientTest.testInitial(TelnetClientTest.java:120)
>     [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     [junit] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>     [junit] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 
> 
> BUILD FAILED
> /home/gump/workspaces2/public/workspace/jakarta-commons/net/build.xml:93: Test org.apache.commons.net.telnet.TelnetClientTest failed
> 
> Total time: 28 seconds
> ---------------------------------------------
> 
> To subscribe to this information via syndicated feeds:
> - RSS: http://brutus.apache.org/gump/public/jakarta-commons/commons-net/rss.xml
> - Atom: http://brutus.apache.org/gump/public/jakarta-commons/commons-net/atom.xml
> 
> ============================== Gump Tracking Only ===
> Produced by Gump version 2.2.
> Gump Run 37000010012005, brutus:brutus-public:37000010012005
> Gump E-mail Identifier (unique within run) #8.
> 
> --
> Apache Gump
> http://gump.apache.org/ [Instance: brutus]
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org