commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: [jelly] Paul's recently applied patch to xml tag library
Date Sun, 30 Jan 2005 02:15:37 GMT
I didn't see anything committed?

Anyway, I'm finding other bugs in x:set (with or without patch), but 
I'll wait until the newer version to investigate in case it changes.

- Brett

Paul Libbrecht wrote:

>
> Sounds great.
> Have just committed...
> - more tests
> - empty-handling as before
> To test, I simply modified 
> <maven.local.home>/cache/maven-xdoc-plugin/project.xml to depend on 
> the latest jelly:xml... and the [] I got were all in some java kind of 
> code... was this enough test ? I hope... I'm fading away.
>
> Before releasing, I'd really like an x:switch... I found this several 
> times painfully missing... (or an x:when to be a child of j:switch!). 
> But maybe this makes people wait too much...
>
> paul
>
>
> Le 30 janv. 05, à 02:10, Brett Porter a écrit :
>
>> Yep! What do you say to releasing xml-1.1 once we are happy with it?
>>
>> - Brett
>>
>> Paul Libbrecht wrote:
>>
>>> Le 30 janv. 05, à 00:49, Brett Porter a écrit :
>>>
>>>> Sorry for the ordinary bug report... it was kind of late :)
>>>> It's in the links template in site.jsl on latest SVN.
>>>>   <j:set var="_img"><x:expr select="@img"/></j:set>
>>>> _img is [].
>>>> I'm not sure where the x:set comes into it, but reverting that 
>>>> revision of that file fixes it.
>>>> @img is detected as a NODE_LIST when it probably should be a single 
>>>> value.
>>>
>>>
>>>
>>> Right... I reviewed in details the patch of Michael Schuerig under 
>>> that respect and found, precisely, that empty things were turned 
>>> into lists...
>>> I have now unit-tests to check these and am rewriting in my previous 
>>> style his feature, with his it was too much details.
>>> If all my tests work, that should be working and it should make 
>>> x:set without any asString, delimiter, or singe attribute should 
>>> behave exactly as when james left it.
>>>
>>> Ok with that ?
>>>
>>> paul
>>>
>>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message