commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Mitchell" <jmitch...@apache.org>
Subject Re: [chain] CopyCommand
Date Fri, 07 Jan 2005 18:55:17 GMT
I am a committer on Struts and a few Sandbox items, if I had the karma, I 
could fix this add a few more tests that demonstrate/validate the fix.

I don't recall if there needs to be a vote.

Martin? Ted? Craig?



--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx

----- Original Message ----- 
From: "Sean Schofield" <sean.schofield@gmail.com>
To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Sent: Friday, January 07, 2005 1:47 PM
Subject: Re: [chain] CopyCommand


> You are correct.  Actually, someone reported this bug already a few days 
> ago:
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=32894
>
> For those [chain] committers who are listening, I submitted a patch
> for that and its still waiting ;-)
>
> sean
>
>
> On Fri, 7 Jan 2005 13:11:22 -0500, James Mitchell <jmitchell@apache.org> 
> wrote:
>> Just poking around in the source (for my own learning) and came across 
>> this
>> bit of code.
>>
>> I won't even pretend to know what this is supposed to do, but unless I'm 
>> way
>> off, shouldn't this
>> doing " value = context.get(getFromKey()); " on line 5?
>>
>> 1  public boolean execute(Context context) throws Exception {
>> 2
>> 3    Object value = this.value;
>> 4        if (value == null) {
>> 5            context.get(getFromKey());
>> 6        }
>> 7    if (value != null) {
>> 8        context.put(getToKey(), value);
>> 9    } else {
>> 10        context.remove(getToKey());
>> 11    }
>> 12    return (false);
>> 13
>> 14  }
>> 15
>>
>> --
>> James Mitchell
>> Software Engineer / Open Source Evangelist
>> EdgeTech, Inc.
>> 678.910.8017
>> AIM: jmitchtx
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message