commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Pugh" <ep...@upstate.com>
Subject RE: [configuration] getProperty vs getPropertyDirect
Date Thu, 02 Dec 2004 20:22:14 GMT
At one time we had all sorts of abstraction somewhere in there..  I think
for example JNDIConfiguration supported "removing" properites by holding
them in a temporary list of properties that had been removed.  If
getProperty() found that the list had a property with that name, then it
returned null, otherwise it called getPropertyDirect which ACTUALLY returned
the property.

Icky, I know, and getting rid of it has my earnest +1!   Just the
similiarity of the names always seemed like a code smell to me.

Eric

> -----Original Message-----
> From: Emmanuel Bourg [mailto:smanux@lfjr.net]
> Sent: Thursday, December 02, 2004 6:51 PM
> To: Jakarta Commons Developers List
> Subject: [configuration] getProperty vs getPropertyDirect
>
>
> Dumb question of the day : what's the usefulness of getPropertyDirect ?
> I cleaned a bit the code by removing the redundant getProperty
> implementation in CompositeConfiguration and JNDIConfiguration, now the
> only implementation left is in AbstractConfiguration and it delegates
> directly to getPropertyDirect.
>
> So at this point it seems getPropertyDirect is no longer necessary, I
> suggest merging it into getProperty.
>
> Emmanuel Bourg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message