commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 32350] - [chain] Consider making lookup commands default to same chain
Date Thu, 02 Dec 2004 15:08:31 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=32350>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32350





------- Additional Comments From sean.schofield@gmail.com  2004-12-02 16:08 -------
After thinking about this for a while I think Joe has a good point about it 
being a bit clumsy to have to specify the catalog in LookupCommand if the 
command/chain being looked up is in the same catalog.  Using a default catalog 
for CatalogFactory makes perfect sense, but I'm not so sure its desirable for 
the LookupCommand to use the default Catalog.  The more I think about it, the 
more I agree with Joe that the more natural behavior would be for 
LookupCommand to default to the same catalog that the LookupCommand is in.

Can we agree that this would be a desirable outcome if we could come up with a 
elegant solution?  Count me as a +1 as far as the outcome is concerned.

I would also agree with Craig's critique of the initial solution proposed by 
Joe.  I don't think we want to tie Catalogs and Commands together explicitly 
through the public API (ex. Command::setCatalog).  The trick would be to find 
a way to make LookupCommand aware of its own catalog.

Joe mentioned that perhaps we could use the Context.  I looked into this, but 
I don't see how that information could be put into the context as part of any 
class that its in commons-chain.  Obviously the programmer could do this, but 
that's a bit of a hack.  

As it stands now the Context is the only real way to link a Command to its 
Catalog.  I like how the Command interface is a single simple method so I 
would suggest we leave that alone.

Bottom line is that I agree with the intent of the enhancement and feel that 
we should work within the existing Command interface.  If it can be done this 
way, then I think its a good idea.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message