Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 89601 invoked from network); 15 Nov 2004 09:18:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 15 Nov 2004 09:18:11 -0000 Received: (qmail 83352 invoked by uid 500); 15 Nov 2004 09:18:09 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 83281 invoked by uid 500); 15 Nov 2004 09:18:08 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 83267 invoked by uid 99); 15 Nov 2004 09:18:08 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=RCVD_BY_IP,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of melowe@gmail.com designates 64.233.184.200 as permitted sender) Received: from [64.233.184.200] (HELO wproxy.gmail.com) (64.233.184.200) by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 15 Nov 2004 01:18:04 -0800 Received: by wproxy.gmail.com with SMTP id 37so311262wra for ; Mon, 15 Nov 2004 01:18:01 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=HX5gGP9U79qeXWuLV3PquWlqHScBE7XFD+8N4OsaxN3/xdCZvlDA8QoK2UVT1LUDLL88/il2+A+odo9GL6W8ViuO4N6/wri2ALu01/lIEXk2lEkG+oL6fFH4/SecKUhZvWD+jRzJNCjOjwZwlSYoDsvCnNjbE9DLsPPPGMbZEuA= Received: by 10.54.49.6 with SMTP id w6mr128148wrw; Mon, 15 Nov 2004 01:18:00 -0800 (PST) Received: by 10.54.27.56 with HTTP; Mon, 15 Nov 2004 01:18:00 -0800 (PST) Message-ID: <3e1257da041115011860e2e8c0@mail.gmail.com> Date: Mon, 15 Nov 2004 10:18:00 +0100 From: Mark Lowe Reply-To: Mark Lowe To: Jakarta Commons Developers List , epugh@upstate.com Subject: Re: DO NOT REPLY [Bug 32094] - [email] All exceptions seem to be thrown as messagingExceptions Cc: Corey Scott In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N I don't mind.. But seems that Javamail already has some exceptions that we're not using why not use them more adding any new ones? If we though the UnsupportedEncodingException in the right place, and then silence is in a reuseable createAddress method.. that should work shouldn't it? It seems reasonable to inform the user that the encoding s/he is trying is dodgy, if done on setCharset() . Likewise an addressexception when setting addresses. I think also controlling the javamail exceptions seems to fit with the idea of being a bridge between javamail and something simpler. Mark On Mon, 15 Nov 2004 09:07:16 -0000, Eric Pugh wrote: > So, we are agreed that we should have an EmailException that should be > thrown? And that will wrap any underlying exception? > > EmailException should extend NestableException. > > Eric > > > > > -----Original Message----- > > From: Corey Scott [mailto:corey.scott@gmail.com] > > Sent: Monday, November 15, 2004 6:18 AM > > To: Jakarta Commons Developers List; Mark Lowe > > Subject: Re: DO NOT REPLY [Bug 32094] - [email] All exceptions seem to > > be thrown as messagingExceptions > > > > > > I also like these ideas and am happy to help you implement them if you > > would like. However there is one thing we may want to be aware of. I > > dont think that the setCharset causes the UnsupportedCharsetException > > to be throw, I believe that it doesn't check it and therefore allows > > for any value to be set. As we are trying to keep email small and > > maintainable, I dont think it is a good idea to try to added > > verfication to our classes. That said, I believe that the only value > > I came accross during testing that did throw this exception was the > > setName part of the addresses. Therefore the unsupported charset > > exception is thrown for all of the setFrom, addTo, addCc, addBcc, etc > > functions only at the moment. > > > > I hope this helps, > > Corey > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org > > For additional commands, e-mail: commons-dev-help@jakarta.apache.org > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org > For additional commands, e-mail: commons-dev-help@jakarta.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org