commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject [IO] FilenameUtils#getPrefixLength is broken on Unix
Date Fri, 26 Nov 2004 07:56:40 GMT
Hi,

this is the manual version of what Gump is trying to tell you 8-)

FilenameUtils.getPrefixLength fails on Unix if you pass a string of
length one as argument since it unconditionally tries to access the
second character (just to never use it).  Therefore the test case
fails since it tests "/".

The trivial patch appended fixes this problem

It will not fix the build since the tests still fails, but I'm not
sure whether the code ot the test is wrong.  The test failure
remaining is

    [junit] Testcase: testNormalize took 0,02 sec
    [junit] 	FAILED
    [junit] Check if '/../' normalized to 'null', was '' expected:<null> but was:<>
    [junit] junit.framework.ComparisonFailure: Check if '/../' normalized to 'null', was ''
expected:<null> but was:<>

Cheers

        Stefan

Index: io/src/java/org/apache/commons/io/FilenameUtils.java
===================================================================
RCS file: /home/cvspublic/jakarta-commons/io/src/java/org/apache/commons/io/FilenameUtils.java,v
retrieving revision 1.27
diff -u -r1.27 FilenameUtils.java
--- io/src/java/org/apache/commons/io/FilenameUtils.java	23 Nov 2004 00:04:29 -0000	1.27
+++ io/src/java/org/apache/commons/io/FilenameUtils.java	26 Nov 2004 07:51:24 -0000
@@ -416,7 +416,6 @@
             }
         } else {
             char ch0 = filename.charAt(0);
-            char ch1 = filename.charAt(1);
             if (ch0 == '~') {
                 if (len == 1) {
                     return -1;


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message