commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Pugh" <ep...@upstate.com>
Subject RE: DO NOT REPLY [Bug 32094] - [email] All exceptions seem to be thrown as messagingExceptions
Date Mon, 15 Nov 2004 09:37:51 GMT
It seems like having a default charset, and being able to override it is the
way to go.  After all, we are aiming to provide a convenience layer.  Most
developers don't have to deal with the charset at all...

> -----Original Message-----
> From: Mark Lowe [mailto:melowe@gmail.com]
> Sent: Monday, November 15, 2004 8:45 AM
> To: Corey Scott
> Cc: Jakarta Commons Developers List
> Subject: Re: DO NOT REPLY [Bug 32094] - [email] All exceptions seem to
> be thrown as messagingExceptions
>
>
> Opps.. I'd need to watch teh null pointer exception also :o)
>
>
> On Mon, 15 Nov 2004 09:43:29 +0100, Mark Lowe <melowe@gmail.com> wrote:
> > I'm not sure what this class is for but it can be used to check
> char sets
> >
> > java.nio.charset.Charset
> >
> >     public void setCharset(String newCharset)
> >         throws UnsupportedEncodingException
> >     {
> >         if (Charset.isSupported(newCharset))
> >         {
> >             this.charset = newCharset;
> >         }
> >         else
> >         {
> >             throw new UnsupportedEncodingException("Charset unknown");
> >         }
> >     }
> >
> > This would mean that although we'd still need to catch the UEE is
> > would never have any real likelyhood of getting thown.
> >
> > If we chose a default charset we can also shorten the address creation
> > to something like
> >
> > private InternetAddress createAddress(String name, String email)
> >         throws AddressException
> >     {
> >
> >         InternetAddress address = null;
> > try
> > new InternetAddress(email, name, this.charset);
> > } catch(UEE e) {
> >
> > }
> >         address.validate();
> >         return address;
> >     }
> >
> > Would be okay wouldn't it?
> >
> > Mark
> >
> >
> >
> > On Mon, 15 Nov 2004 14:17:57 +0800, Corey Scott
> <corey.scott@gmail.com> wrote:
> > > I also like these ideas and am happy to help you implement them if you
> > > would like.  However there is one thing we may want to be aware of.  I
> > > dont think that the setCharset causes the UnsupportedCharsetException
> > > to be throw, I believe that it doesn't check it and therefore allows
> > > for any value to be set.  As we are trying to keep email small and
> > > maintainable, I dont think it is a good idea to try to added
> > > verfication to our classes.  That said, I believe that the only value
> > > I came accross during testing that did throw this exception was the
> > > setName part of the addresses.  Therefore the unsupported charset
> > > exception is thrown for all of the setFrom, addTo, addCc, addBcc, etc
> > > functions only at the moment.
> > >
> > > I hope this helps,
> > > Corey
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message