commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31918] - javadoc FTPClient inconsistent
Date Tue, 23 Nov 2004 19:43:55 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31918>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31918


dfs@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




------- Additional Comments From dfs@apache.org  2004-11-23 20:43 -------
I think this change is incorrect.  The example code in
the documentation is for how to connect.  Why would you disconnect
immediately after connecting?  The report (sorry I didn't spot it
when it was filed; too much mail and all that) should have been
marked invalid as far as I can tell.  At the worst, after the ugly
catch block, one could add
   ... // Transfer files
   ftp.disconnect();

Basically, the example is exactly what's in example/ftp.java, which--
other than the ugly mess of try/catches--has nothing wrong with it.
If you add ftp.discconnect() inside of the connection establishment
block, then ftp.java won't work at all.

I think the more approprirate way to correct whatever lack of clarity
there is in the javadoc is to change
  For example:
to
  For example, to establish a connection you would do the following:

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message