commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Cooper <mfncoo...@gmail.com>
Subject Re: cvs commit: jakarta-commons/chain/src/java/org/apache/commons/chain/web/servlet ChainProcessor.java ServletApplicationScopeMap.java ServletHeaderValuesMap.java ServletRequestScopeMap.java ServletSessionScopeMap.java
Date Tue, 30 Nov 2004 18:00:07 GMT
On Tue, 30 Nov 2004 00:06:52 -0800, Craig McClanahan <craigmcc@gmail.com> wrote:
> -1
> 
> Besides the fact that this change bundle breaks the "ant clean dist"
> command that is necessary for the current ngihtly build scripts to
> work

I don't believe that's why the build broke. The problem is that, for
some reason, the JSF jar files have disappeared from ibiblio. I don't
know how to fix that.

>, it alters the semantics with changes like this:

How does it change the semantics? All of 'public', 'static' and
'final' are redundant here, because this is an interface.

--
Martin Cooper


> 
> 
> >   Index: Catalog.java
> >   ===================================================================
> >   RCS file: /home/cvs/jakarta-commons/chain/src/java/org/apache/commons/chain/Catalog.java,v
> >   retrieving revision 1.6
> >   retrieving revision 1.7
> >   diff -u -r1.6 -r1.7
> >   --- Catalog.java      25 Feb 2004 00:01:07 -0000      1.6
> >   +++ Catalog.java      30 Nov 2004 05:52:22 -0000      1.7
> >   @@ -37,7 +37,7 @@
> >         * <p>A default context attribute for storing a default {@link Catalog},
> >         * provided as a convenience only.</p>
> >         */
> >   -    public static final String CATALOG_KEY = "org.apache.commons.chain.CATALOG";
> >   +    String CATALOG_KEY = "org.apache.commons.chain.CATALOG";
> >
> >        /**
> >
> 
> Craig
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message