commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne" <scolebou...@btopenworld.com>
Subject Re: [PATCH] collections: Fix static access warning in TreeBidiMap
Date Fri, 12 Nov 2004 00:07:48 GMT
Changes made.
For future reference, it is better to attach patches to a Bugzilla call, as
email messes up the patch format

Thanks
Stephen

----- Original Message -----
From: "Chris Tilden" <chris.tilden@gmail.com>
To: <commons-dev@jakarta.apache.org>
Sent: Thursday, November 11, 2004 1:43 AM
Subject: [PATCH] collections: Fix static access warning in TreeBidiMap


> ### I opened the collections source using Eclipse 3.0.1 and noticed a
> ### warning, this patch fixes that warning.
> Index:
collections/src/java/org/apache/commons/collections/bidimap/TreeBidiMap.java
> ===================================================================
> ---
a/collections/src/java/org/apache/commons/collections/bidimap/TreeBidiMap.ja
va
>  2004-11-08 13:24:19.512553800 -0800
> +++
b/collections/src/java/org/apache/commons/collections/bidimap/TreeBidiMap.ja
va
>  2004-11-08 13:33:53.112353376 -0800
> @@ -1612,7 +1612,7 @@
>              expectedModifications++;
>              lastReturnedNode = null;
>              if (nextNode == null) {
> -                previousNode =
> main.greatestNode(main.rootNode[orderType], orderType);
> +                previousNode =
> TreeBidiMap.greatestNode(main.rootNode[orderType], orderType);
>              } else {
>                  previousNode = main.nextSmaller(nextNode, orderType);
>              }
> @@ -1674,7 +1674,7 @@
>           */
>          EntryView(final TreeBidiMap main, final int orderType, final
> int dataType) {
>              super(main, orderType, dataType);
> -            this.oppositeType = main.oppositeIndex(orderType);
> +            this.oppositeType = TreeBidiMap.oppositeIndex(orderType);
>          }
>
>          public boolean contains(Object obj) {
> @@ -1979,14 +1979,14 @@
>              if (main.nodeCount == 0) {
>                  throw new NoSuchElementException("Map is empty");
>              }
> -            return main.leastNode(main.rootNode[VALUE],
VALUE).getValue();
> +            return TreeBidiMap.leastNode(main.rootNode[VALUE],
> VALUE).getValue();
>          }
>
>          public Object lastKey() {
>              if (main.nodeCount == 0) {
>                  throw new NoSuchElementException("Map is empty");
>              }
> -            return main.greatestNode(main.rootNode[VALUE],
VALUE).getValue();
> +            return TreeBidiMap.greatestNode(main.rootNode[VALUE],
> VALUE).getValue();
>          }
>
>          public Object nextKey(Object key) {
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message