Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Message-ID: <1731779066.1096918832578.JavaMail.apache@nagoya>
Date: Mon, 4 Oct 2004 12:40:32 -0700 (PDT)
From: commons-dev@jakarta.apache.org
To: commons-dev@jakarta.apache.org
Subject: [jira] Commented: (JELLY-150) j:forEach tag not properly using
 varStatus attribute
In-Reply-To: <1070271737.1096027112161.JavaMail.apache@nagoya>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

The following comment has been added to this issue:

     Author: Ben Anderson
    Created: Mon, 4 Oct 2004 12:40 PM
       Body:
The interface is defined here:
http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/jstl/core/LoopTagSupport.html

There was some discussion following this on the mailing list. Personally, I don't see why it can't go in javax.servlet, but it should be fine to put it in some other package.  Does your "unified format" comment pertain to the diff file I posted?  This is the first patch I've ever submitted.  I wasn't sure what to do with the new files, so I appended them to that file.  I'm assuming this is not the way to do it, but I didn't know how.  If someone will let me know how I'm supposed to do it, I'll resubmit the correctly formatted file.

---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53683

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JELLY-150

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JELLY-150
    Summary: j:forEach tag not properly using varStatus attribute
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: jelly
 Components: 
             core / taglib.core
   Versions:
             1.0-beta-4
             1.0
             1.1-beta-1
             jface-1.0-beta-1
             jface-1.0
             swt-1.0
             1.0-beta-5

   Assignee: 
   Reporter: Ben Anderson

    Created: Fri, 24 Sep 2004 4:57 AM
    Updated: Mon, 4 Oct 2004 12:40 PM
Environment: win2k / cygwin

Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus.  Currently a variable is set with type Integer which contains the index of the current iteration.  I created a test case (I don't think any existed for forEach) that demonstrates this.  I also began making the fix, but it doesn't fully work.  I am submitting my patch along with the test cases.  The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope).  I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before.  I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help.  Thanks! :-)


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org