commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig McClanahan <craig...@gmail.com>
Subject Re: [chain] New interface: CatalogFactory
Date Sat, 02 Oct 2004 19:26:09 GMT
On Thu, 30 Sep 2004 15:23:42 -0400, Sean Schofield
<sean_schofield@schof.com> wrote:
> Attached is the new CatalogFactory interface that I proposed a while
> back.  I welcome any comments, concerns or objections.  I will be
> providing a default implentation (as Craig has suggested) but I'd like
> to get feedback on the interface first.
> 
> Thanks,
> sean

Hi Sean,

I've committed your proposed CatalogFactory.java interface to [chain],
with minor tweaks to the Javadoc comments to conform to the usual
style in [chain].  I've got a couple of questions to start with.

The getInstance() method seems out of place here ... in most factory
pattern implementations I've seen, this would actually be a public
static method on an implementation of CatalogFactory.  What kind of
use cases do you see for it here?

Also, your original motivation was to disconnect catalog lookups from
something like the ServletContext attribute that ChainListener
(containing a Catalog) sets up.  How are you proposing to do this
disconnect -- I presume it's something in the actual implementation of
CatalogFactory?  If so, will your proposed solution work when
commons-chain.jar is included either in the WEB-INF/lib directory, and
when it's installed in the servet container (thus making static
variables global across webapps)?

Craig


> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 
> 
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message