commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From commons-...@jakarta.apache.org
Subject [jira] Commented: (JELLY-148) Huge memory leak resulting from the use of ThreadLocal
Date Wed, 13 Oct 2004 04:37:51 GMT
The following comment has been added to this issue:

     Author: Hans Gilde
    Created: Tue, 12 Oct 2004 9:37 PM
       Body:
I uploaded patches that fix the immediate problem. I also checked all existing tag libs for
the pattern that causes the problem: iterating down through one's Scripts, checking their
type with instanceof. Only the XML tags do this.

Of course, it's totaly bogus to do this and it should be explicitly disallowed. However, I'm
actually am somewhat stumped by a particular behavior of the XML output and wasn't able to
replace this functionality with something better.

For 1.1/2.0/sometime soon, we should fix the underlying condition in the XML tags, which is
harder than it looks at first. I'll file a jira about it.

For now, the patch passes the unit tests.
---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/JELLY-148?page=comments#action_53977

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JELLY-148

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JELLY-148
    Summary: Huge memory leak resulting from the use of ThreadLocal
       Type: Bug

     Status: Unassigned
   Priority: Critical

    Project: jelly
 Components: 
             core / taglib.core
   Versions:
             1.0

   Assignee: 
   Reporter: Hans Gilde

    Created: Sat, 18 Sep 2004 9:34 PM
    Updated: Tue, 12 Oct 2004 9:37 PM

Description:
There is a huge memory leak that results from the TagScript's use of ThreadLocal.

ThreadLocal is usually used from a staic variable, while TagScript uses it from an instance
variable. Although this looks legal to me, it causes a huge memory leak.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message