commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31329] - [PATCH] Support for evaluating a predicate when determining if a rule is valid for a given element
Date Thu, 07 Oct 2004 20:02:44 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31329>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31329

[PATCH] Support for evaluating a predicate when determining if a rule is valid for a given
element





------- Additional Comments From rdonkin@apache.org  2004-10-07 20:02 -------
Sounds like an interesting idea (but I don't have the time to analyse it properly right now).
I have a few 
comments.

For Digester 1 (at least), it's a pity that we're constrained by backwards compatibility.
Digester was one 
of the first commons components and we've learnt a lot since then. One lesson is that it's
often better 
to implement logical interfaces as abstract classes rather than java interfaces. (If rules
had been an 
abstract class we could have easily retrofitted this extra capability.) Another is that all
access to 
instances variables should be through setter and getters - even from subclasses. All those
protected 
variables are great for those creating subclasses but limit the options for replacing Rules
with 
something better.

I agree with Simon that it's probably best to use a digester-specific predicate.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message