commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From commons-...@jakarta.apache.org
Subject [jira] Commented: (JELLY-148) Huge memory leak resulting from the use of ThreadLocal
Date Sat, 02 Oct 2004 17:48:33 GMT
The following comment has been added to this issue:

     Author: Hans Gilde
    Created: Sat, 2 Oct 2004 10:47 AM
       Body:
Yes, sorry to take so long but I've been trying to find a better solution.

The idea with the parent-weak-references doesn't really work.

The idea about keeping the cache in the regular context HashMap doesn't work either. It gets
screwed up if you change the inherit/export setting on the JellyContext.

This leaves these options:

* The body-as-weak-reference patch that I originally posted
* change JellyContext as suggested by Guido 
* change the Script interface to allow a parent to pass down their Tag.

The only problem with option 2 is that we're likely to make an API change, only to make another
change later.

I vote for option 1, which puts us back to the patch thread-local-memory-fix-demo.txt 
---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/JELLY-148?page=comments#action_53623

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JELLY-148

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JELLY-148
    Summary: Huge memory leak resulting from the use of ThreadLocal
       Type: Bug

     Status: Unassigned
   Priority: Critical

    Project: jelly
 Components: 
             core / taglib.core
   Versions:
             1.0

   Assignee: 
   Reporter: Hans Gilde

    Created: Sat, 18 Sep 2004 9:34 PM
    Updated: Sat, 2 Oct 2004 10:47 AM

Description:
There is a huge memory leak that results from the TagScript's use of ThreadLocal.

ThreadLocal is usually used from a staic variable, while TagScript uses it from an instance
variable. Although this looks legal to me, it causes a huge memory leak.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message