commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From commons-...@jakarta.apache.org
Subject [jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Date Wed, 06 Oct 2004 13:55:32 GMT
The following comment has been added to this issue:

     Author: Ben Anderson
    Created: Wed, 6 Oct 2004 6:54 AM
       Body:
- You are creating a new LoopTagStatus class each time through the loop, I was reusing a single
instance.
agreed - good catch!

- You only handled one branch in the ForEachTag code.
I'm unsure what you mean here.

- You removed the indexVar, whereas I left it alone.
agreed - better to leave it.

- Your logic for isLast is easier, but relies on the itemsSize private variable, which should
be declared inside doTag, and which doesn't handle iterators. 
agreed - I new I didn't do that the best way, but wasn't sure how to do it better.  Yours
looks good!
---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53758

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JELLY-150

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JELLY-150
    Summary: j:forEach tag not properly using varStatus attribute
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: jelly
 Components: 
             core / taglib.core
   Versions:
             1.0-beta-4
             1.0-beta-5
             swt-1.0
             jface-1.0
             jface-1.0-beta-1
             1.1-beta-1
             1.0

   Assignee: 
   Reporter: Ben Anderson

    Created: Fri, 24 Sep 2004 4:57 AM
    Updated: Wed, 6 Oct 2004 6:54 AM
Environment: win2k / cygwin

Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should
create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus.  Currently a variable
is set with type Integer which contains the index of the current iteration.  I created a test
case (I don't think any existed for forEach) that demonstrates this.  I also began making
the fix, but it doesn't fully work.  I am submitting my patch along with the test cases. 
The comments I placed in the code should be enough to tip someone off as to why it's not working
(I hope).  I am relatively new to jelly (been using the standard taglibs for awhile) and have
never opened the source before.  I am willing to complete the patch, but will probably need
some guidance because I messed with it for awhile before determing I couldn't complete without
some help.  Thanks! :-)


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message