commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hans Gilde <hgilde-comm...@earthlink.net>
Subject RE: (JELLY-150) j:forEach tag not properly using varStatus attribute
Date Tue, 05 Oct 2004 01:14:32 GMT
Ben,

Now I see what you did with the patch. See
http://jakarta.apache.org/commons/patches.html for the diff command. All you
have to do is include the new files on the end of cvs diff -u and they'll be
a part of the patch.

Hans

-----Original Message-----
From: Ben Anderson [mailto:benanderson@benanderson.us] 
Sent: Monday, October 04, 2004 6:08 AM
To: Jakarta Commons Developers List
Subject: Re: (JELLY-150) j:forEach tag not properly using varStatus
attribute

no, it belongs in javax.servlet.
http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/jstl/co
re/LoopTagSupport.html
Does your "unified format" comment pertain to the diff file I posted?  This
is
the first patch I've ever submitted.  I wasn't sure what to do with the new
files, so I appended them to that file.  I'm assuming this is not the way to
do
it, but I didn't know how.  If someone will let me know how I'm supposed to
do
it, I'll do it when I get home tonight (I can't access Jira here at work)
Thanks,
Ben

Quoting commons-dev@jakarta.apache.org:

> The following comment has been added to this issue:
>
>      Author: Hans Gilde
>     Created: Sat, 2 Oct 2004 9:30 PM
>        Body:
> This patch adds a class in the package javax.servlet. This is a no-no.
> Everything should be in a jelly packge. Maybe LoopTagStatus should be a
> public static inner class of LoopTagStatus?
>
> Also, this patch isn't the Unified format.
>
> I haven't looked over the logic, yet, just the structure.
>
> ---------------------------------------------------------------------
> View this comment:
>
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53634
>
> ---------------------------------------------------------------------
> View the issue:
>   http://issues.apache.org/jira/browse/JELLY-150
>
> Here is an overview of the issue:
> ---------------------------------------------------------------------
>         Key: JELLY-150
>     Summary: j:forEach tag not properly using varStatus attribute
>        Type: Bug
>
>      Status: Unassigned
>    Priority: Major
>
>     Project: jelly
>  Components:
>              core / taglib.core
>    Versions:
>              1.0-beta-4
>              1.0
>              1.1-beta-1
>              jface-1.0-beta-1
>              jface-1.0
>              swt-1.0
>              1.0-beta-5
>
>    Assignee:
>    Reporter: Ben Anderson
>
>     Created: Fri, 24 Sep 2004 4:57 AM
>     Updated: Sat, 2 Oct 2004 9:30 PM
> Environment: win2k / cygwin
>
> Description:
> According to the jstl specification 1.1, the varStatus attribute of the
> forEach tag should create a variable with type
> javax.servlet.jsp.jstl.core.LoopTagStatus.  Currently a variable is set
with
> type Integer which contains the index of the current iteration.  I created
a
> test case (I don't think any existed for forEach) that demonstrates this.
I
> also began making the fix, but it doesn't fully work.  I am submitting my
> patch along with the test cases.  The comments I placed in the code should
be
> enough to tip someone off as to why it's not working (I hope).  I am
> relatively new to jelly (been using the standard taglibs for awhile) and
have
> never opened the source before.  I am willing to complete the patch, but
will
> probably need some guidance because I messed with it for awhile before
> determing I couldn't complete without some help.  Thanks! :-)
>
>
> ---------------------------------------------------------------------
> JIRA INFORMATION:
> This message is automatically generated by JIRA.
>
> If you think it was sent incorrectly contact one of the administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
>
> If you want more information on JIRA, or have a bug to report see:
>    http://www.atlassian.com/software/jira
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>




---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message