commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne" <scolebou...@btopenworld.com>
Subject Re: [lang] bug#30929 - use isAssignableFrom
Date Fri, 08 Oct 2004 22:58:36 GMT
I was going to make the change, but fixing the tests emphasises that this is
not an acceptable 'bug fix'. Thus I am -1 on the change.

I intend to commit parallel methods - indexOfType - and Javadoc to cover the
bug report instead. The only downside is that the interface (Nestable)
cannot be changed.

Stephen

----- Original Message -----
From: "Steven Caswell" <steve@mungoknotwise.com>
The bug author makes a good point. I'm +1 to making the change.


Steven Caswell
Sun Certified Java Programmer
steve@mungoknotwise.com
"War is an ugly thing, but not the ugliest of things. The decayed and
degraded state of moral and patriotic feeling that thinks that nothing is
worth war is much worse. The person who has nothing for which he is willing
to fight, nothing which is more important than his own personal safety, is a
miserable creature and has no chance of being free unless made and kept so
by the exertions of better men than himself." .... John Stuart Mill.


> -----Original Message-----
> From: Henri Yandell [mailto:flamefew@gmail.com]
> Sent: Thursday, September 30, 2004 2:06 AM
> To: Jakarta Commons Developers List
> Subject: [lang] bug#30929 - use isAssignableFrom
>
>
> I think this bug makes sense:
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=30929
>
> Assuming no one disagrees, do we want to make the change in
> indexOfThrowable or create a new method? The javadoc for
> indexOfThrowable says 'type', which to me would imply
> inheritence is adhered to.
>
> I ask as the unit tests fail if the change is made and before
> I'd rather not waste the time on them if people are against
> the change.
>
> Hen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message