Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 23833 invoked from network); 30 Sep 2004 12:56:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 30 Sep 2004 12:56:23 -0000 Received: (qmail 85909 invoked by uid 500); 30 Sep 2004 12:56:18 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 85804 invoked by uid 500); 30 Sep 2004 12:56:17 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 85789 invoked by uid 99); 30 Sep 2004 12:56:17 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=RCVD_BY_IP,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of flamefew@gmail.com designates 64.233.170.194 as permitted sender) Received: from [64.233.170.194] (HELO mproxy.gmail.com) (64.233.170.194) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 30 Sep 2004 05:56:15 -0700 Received: by mproxy.gmail.com with SMTP id 79so3538385rnk for ; Thu, 30 Sep 2004 05:56:14 -0700 (PDT) Received: by 10.38.70.21 with SMTP id s21mr498690rna; Thu, 30 Sep 2004 05:56:13 -0700 (PDT) Received: by 10.38.164.33 with HTTP; Thu, 30 Sep 2004 05:56:13 -0700 (PDT) Message-ID: <31cc373604093005566512c96c@mail.gmail.com> Date: Thu, 30 Sep 2004 08:56:13 -0400 From: Henri Yandell Reply-To: Henri Yandell To: Jakarta Commons Developers List Subject: Re: [validator] ISBNValidator In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Having a quick peek, I don't see any code in there to handle X being 10. Have you tested it for an ISBN with an X of 10 yet. Currently it looks as though it strips out X's. Submitting a unit-test class as well is always very useful, especially with new classes. Hen On Thu, 30 Sep 2004 12:53:43 +0200, Mark Lowe wrote: > Hello > > I've just written an ISBN validator I don't think i can diff a file > that doesn't exist. But i'd like to see if its of use to anyone other > than myself. > > I've attached it and i'll just check the commons stuff out of cvs and > see if there's a jalopy template that could iron out anything that > would be displeasing to anyone in terms of coding. > > What do i have to do to get this committed? > > I still need to add an option to switch checking the regular expression > off in case folk want to use it to check numbers with no hyphens or > spaces. At the moment the input can be either. > > Mark > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org > For additional commands, e-mail: commons-dev-help@jakarta.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org