Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Received-SPF: neutral (hermes.apache.org: 167.206.5.70 is neither permitted
 nor denied by domain of hgilde-commons@earthlink.net)
Date: Fri, 24 Sep 2004 00:04:32 -0400
From: Hans Gilde <hgilde-commons@earthlink.net>
Subject: RE: [JELLY] Re: j:forEach bug
In-reply-to: <415300E4.9000605@benanderson.us>
To: 'Jakarta Commons Developers List' <commons-dev@jakarta.apache.org>
Message-id: <0I4J004AJ1ZJF8@mta4.srv.hcvlny.cv.net>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: quoted-printable
Thread-index: AcShsMx4Rzd9W3qVTkWJugcybwyEOQAMNf3g


Well... this would definitely be a nice feature.

FYI, Ben, this example/explanation is perfect. The original email about =
a
bug and your patch would have been more concise and easily digested if =
it
included the info in this last email.

If the functionality worked properly in XML but didn't exactly implement
javax.servlet.jsp.jstl.core.LoopTagStatus, would that be good for you?

Hans

-----Original Message-----
From: Ben Anderson [mailto:benanderson@benanderson.us]=20
Sent: Thursday, September 23, 2004 11:59 AM
To: Jakarta Commons Developers List
Subject: [JELLY] Re: j:forEach bug

I'll post my patch to jira tomorrow - I left the code at work.  The JSTL =

compliance I'm referring to is the varStatus attribute, which according=20
to the jstl spec should implement=20
javax.servlet.jsp.jstl.core.LoopTagStatus.  Meanwhile the jelly=20
attribute assigns a variable with type of Integer which is an index.  I=20
would like to do something like this, which works nicely using the=20
Standard 1.1 taglibs.
<j:forEach var=3D"element" items=3D"${list}" varStatus=3D"status">
    <j:if test=3D"${status.last}">
        this is the last time through
    </j:if>
</j:forEach>
I know there are other ways to do this, but is seems to me the jstl way=20
is much nicer ;-)
-Ben

Paul Libbrecht wrote:

> Ben,
>
> There has been several considerations on making j:forEach more jstl =20
> compliant... you might to consider them first:
>
> http://nagoya.apache.org/jira/secure/IssueNavigator.jspa?=20
> =
reset=3Dtrue&mode=3Dhide&summary=3Dtrue&description=3Dtrue&query=3DforEac=
h
>
> Do note that Jelly uses Jira and not Bugzilla!
>
> To make your patch, I think there's an option of "cvs diff" that=20
> allows  a unified diff...
>
> All in all, I haven't understood very well what is the goal of your =20
> change!
>
> Personally, I'd more and more consider the need for forEach to be=20
> JSTL  compliant as somewhat... annoying.
>
> paul
>
> Le 23 sept. 04, =E0 17:28, Ben Anderson a =E9crit :
>
>> I'm new to this list, and developer tasks in Apache projects.  I=20
>> found  a bug in
>> jelly's forEach tag, which is not conformant to jstl.  I've tried to  =

>> fix it and
>> am close (I think), but it's not functioning exactly as I suspected=20
>> it  would.
>> Maybe someone could offer some help.  I want to check the specific =20
>> process for
>> this.  Should I enter a bug in bugzilla?  I can then post my patch =20
>> there?
>> Also, I've added a couple of files(tests).  Do I just append these?   =

>> Somethine
>> like:
>>
>> $cvs diff  -u > site.patch
>> $echo "src/test/org/apache/commons/jelly/core/TestForEachTag.java"=20
>> >>  site.patch
>> $cat src/test/org/apache/commons/jelly/core/TestForEachTag.java >> =20
>> site.patch
>> $echo "src/test/org/apache/commons/jelly/core/testForEachTag.jelly" =20
>> >>site.patch
>> $cat src/test/org/apache/commons/jelly/core/testForEachTag.jelly >> =20
>> site.patch
>>
>> also, like I said this patch isn't complete.  What I'm doing is =20
>> creating an
>> anonymous inner class and setting that in the context.  The jelly =20
>> script
>> recognizes the object, but doesn't proper evaluate it's methods:
>> <!-- this evaluates correctly -->
>> <j:out value=3D"${myClass.class}"/>
>>
>> <!-- the class contains a method getProp1()
>>      but it isn't evaluating correctly -->
>> <j:out value=3D"${myClass.prop1}"/>
>>
>> I'm thinking this may have something to do with it being an=20
>> anonymous  inner
>> class.  Eyeballing my patch would be much easier than me explaining =20
>> here, so I
>> won't go into much detail.  I'm just curious as to the next step I =20
>> should take.
>>
>> Thanks,
>> Ben
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org