commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rory Winston" <rwins...@eircom.net>
Subject RE: DO NOT REPLY [Bug 31272] - TelnetInputStream zombie thread memory leak, FTPClient TelnetClient
Date Fri, 24 Sep 2004 14:55:01 GMT
Actually, just having a quick perusal, I think this may be the culprit
(TelnetInputStream.java):

 __threaded = false;
        if(__threaded)
            __thread = new Thread(this);
        else
            __thread = null;


I've fixed, tested, + committed.

Cheers,
Rory

  if(readerThread)
-----Original Message-----
From: Rory Winston [mailto:rwinston@eircom.net]
Sent: 24 September 2004 15:44
To: Jakarta Commons Developers List
Subject: RE: DO NOT REPLY [Bug 31272] - TelnetInputStream zombie thread
memory leak, FTPClient TelnetClient


Hi,

This fix seems to have broken the TelnetClientTest. Gump probably won't show
it till the next build, but all of the tests in TelnetClinet fail except
one.
I'm not familiar with the Telnet code, and dont have time this afternoon to
look at it. Any ideas?


Testsuite: org.apache.commons.net.telnet.TelnetClientTest
Tests run: 8, Failures: 7, Errors: 0, Time elapsed: 43.032 sec

Testcase:
testOptionNegotiation(org.apache.commons.net.telnet.TelnetClientTest):
FAILED
null
junit.framework.AssertionFailedError
	at
org.apache.commons.net.telnet.TelnetClientTest.testOptionNegotiation(TelnetC
lientTest.java:347)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
	at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:232)
	at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279)
	at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135)
	at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233)
	at org.apache.commons.jelly.tags.core.IfTag.doTag(IfTag.java:88)
	at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279)
	at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135)
	at
org.apache.maven.jelly.tags.werkz.MavenGoalTag.runBodyTag(MavenGoalTag.java:
79)
	at
org.apache.maven.jelly.tags.werkz.MavenGoalTag$MavenGoalAction.performAction
(MavenGoalTag.java:110)
	at com.werken.werkz.Goal.fire(Goal.java:639)
	at com.werken.werkz.Goal.attain(Goal.java:575)
	at com.werken.werkz.Goal.attainPrecursors(Goal.java:488)
	at com.werken.werkz.Goal.attain(Goal.java:573)
	at com.werken.werkz.WerkzProject.attainGoal(WerkzProject.java:193)
	at
org.apache.maven.plugin.PluginManager.attainGoals(PluginManager.java:634)
	at org.apache.maven.MavenSession.attainGoals(MavenSession.java:266)
	at org.apache.maven.cli.App.doMain(App.java:486)
	at org.apache.maven.cli.App.main(App.java:1215)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
	at com.werken.forehead.Forehead.run(Forehead.java:551)
	at com.werken.forehead.Forehead.main(Forehead.java:581)

-----Original Message-----
From: bugzilla@apache.org [mailto:bugzilla@apache.org]
Sent: 24 September 2004 06:08
To: commons-dev@jakarta.apache.org
Subject: DO NOT REPLY [Bug 31272] - TelnetInputStream zombie thread
memory leak, FTPClient TelnetClient


DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31272>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31272

TelnetInputStream zombie thread memory leak, FTPClient TelnetClient

dfs@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From dfs@apache.org  2004-09-24 05:07 -------
Bruno was responsible for adding setReaderThread, so I was kind of hoping
he'd chime in and look at this.  However, it's pretty clear from looking
at the code that he overlooked what happens with TelnetInputStream, so I'm
applying your fix.  Please verify it has the desired effect before closing.
I can't wait until we get rid of TelnetInputStream and TelnetOutputStream
once and for all.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message