commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From commons-...@jakarta.apache.org
Subject [jira] Closed: (JELLY-96) HttpClient cannot be specified in HttpSession
Date Sun, 12 Sep 2004 15:43:38 GMT
Message:

   The following issue has been closed.

   Resolver: dion gillard
       Date: Sun, 12 Sep 2004 8:43 AM

Fixed in 1.1 of the taglib
---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JELLY-96

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JELLY-96
    Summary: HttpClient cannot be specified in HttpSession
       Type: Bug

     Status: Closed
   Priority: Major
 Resolution: FIXED

    Project: jelly
 Components: 
             taglib.http
   Fix Fors:
             1.0-beta-5

   Assignee: 
   Reporter: Jason Horne

    Created: Tue, 11 Nov 2003 3:42 PM
    Updated: Sun, 12 Sep 2004 8:43 AM

Description:
org.apache.commons.jelly.tags.http.SessionTag always creates a new HttpClient rather than
using one provided by the user.

The doTag method should be changed from this:

    public void doTag(XMLOutput xmlOutput) throws JellyTagException {
        if (isProxyAvailable()) {
            _httpClient = new HttpClient();
            _httpClient.getHostConfiguration().setProxy(getProxyHost(), getProxyPort());
        } else {
            _httpClient = new HttpClient();
        }
        
       


...to this:

    public void doTag(XMLOutput xmlOutput) throws JellyTagException {
        if (_httpClient == null)
            _httpClient = new HttpClient();

        if (isProxyAvailable()) {
            _httpClient.getHostConfiguration().setProxy(getProxyHost(), getProxyPort());
        }
        
        invokeBody(xmlOutput);
    }
 



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message