Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 4138 invoked from network); 14 Aug 2004 11:09:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 14 Aug 2004 11:09:15 -0000 Received: (qmail 15399 invoked by uid 500); 14 Aug 2004 11:09:14 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 14991 invoked by uid 500); 14 Aug 2004 11:09:10 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 14977 invoked by uid 99); 14 Aug 2004 11:09:10 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [192.18.33.10] (HELO exchange.sun.com) (192.18.33.10) by apache.org (qpsmtpd/0.27.1) with SMTP; Sat, 14 Aug 2004 04:09:09 -0700 Received: (qmail 29291 invoked by uid 50); 14 Aug 2004 11:10:43 -0000 Date: 14 Aug 2004 11:10:43 -0000 Message-ID: <20040814111043.29290.qmail@nagoya.betaversion.org> From: bugzilla@apache.org To: commons-dev@jakarta.apache.org Cc: Subject: DO NOT REPLY [Bug 30597] - [configuration] HierarchicalConfigurationXMLReader stores comments as text nodes X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30597 [configuration] HierarchicalConfigurationXMLReader stores comments as text nodes epugh@upstate.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Additional Comments From epugh@upstate.com 2004-08-14 11:10 ------- I have applied the fix. I am going to go ahead and close this bug as I want to get as many bugs closed for the RC1 as possible. However, don't let me disuade you from adding a unit test! You may want to at that time add your getXML or toXML method to help with testing. Go ahead and either reopen this bug or submit a fresh bug. Oh, and I view (in good XP fashion) as everythign being a shared responbility. It isn't just my responbility or yours to supply a testcase, but instead a shared responsibility! My only responsibility as a committer is to do my best to encourage people to contribute and ensure that contributions are in good shape and enhance the codebase! Glad to have your participation. Eric --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org