commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From commons-...@jakarta.apache.org
Subject [jira] Commented: (JELLY-116) [PATCH] InvokeTag and InvokeStaticTag should export exception
Date Mon, 16 Aug 2004 03:31:21 GMT
The following comment has been added to this issue:

     Author: Felipe Leme
    Created: Sun, 15 Aug 2004 8:31 PM
       Body:
Sorry, my bad, I used the wrong casts.

Yes, Throwable.getCause() is JDK 1.4, but I'm using InvocationTarget.getTargetMessage() instead:

http://java.sun.com/j2se/1.3/docs/api/java/lang/reflect/InvocationTargetException.html

I mean, there is also a call to jellyException.getCause(), but JellyException defines it indenpendently
on the JDK version.

Anyway, I've just ran maven on it using JDK 1.3.1, and it worked fine. It's just a matter
of modifying the test cases, changing the following line:

from:
 Exception jellyException = (Exception) getJellyContext().getVariable("jellyException");

to:
 JellyException jellyException = (JellyException) getJellyContext().getVariable("jellyException");

And also adding a 

import org.apache.commons.jelly.JellyException;


(Sorry, I'm not with CVS set up right now to send you a patch)
---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/JELLY-116?page=comments#action_37262

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JELLY-116

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JELLY-116
    Summary: [PATCH] InvokeTag and InvokeStaticTag should export exception
       Type: New Feature

     Status: Closed
   Priority: Major
 Resolution: FIXED

    Project: jelly
   Fix Fors:
             1.0-beta-4
   Versions:
             1.0-beta-4

   Assignee: dion gillard
   Reporter: Felipe Leme

    Created: Mon, 9 Aug 2004 6:55 PM
    Updated: Sun, 15 Aug 2004 8:31 PM

Description:
If the method invoked throws a InvocationTargetException, invoke and invokeStatic should allow
the caller to obtain the original exception.

So, I'm providing a patch (including test cases) that export that exception if the exceptionVar
paramater is set (and in this case, it does not throw a JellyTagException). If that parameter
is not set, it assumes the old behaviour (i.e., throws a JellyTagException).



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message