commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory" <ggreg...@seagullsoftware.com>
Subject RE: cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang/builder ToStringStyle.java ToStringBuilder.java
Date Thu, 01 Jul 2004 17:40:34 GMT
> you didn't update all the javadoc.  for example:

Fixed in CVS. Thank you for catching it.

> and shouldn't a new ToStringBuilder on null create the nullText, not
""?

Hm, yes I think so too. In CVS.

Gary

> -----Original Message-----
> From: cananian@cag.csail.mit.edu [mailto:cananian@cag.csail.mit.edu]
On
> Behalf Of C. Scott Ananian
> Sent: Thursday, July 01, 2004 08:57
> To: Jakarta Commons Developers List
> Cc: jakarta-commons-cvs@apache.org
> Subject: Re: cvs commit: jakarta-
> commons/lang/src/java/org/apache/commons/lang/builder
ToStringStyle.java
> ToStringBuilder.java
> 
> On Wed, 30 Jun 2004 ggregory@apache.org wrote:
> 
> >   PR: http://issues.apache.org/bugzilla/show_bug.cgi?id=27876
> >   [lang] ReflectionToStringBuilder.toString(null) throws exception
by
> design
> >   ReflectionToStringBuilder.toString is now null-safe and returns
the
> style's nullText.
> >   ToStringBuilder constructors are now null-safe. A new
ToStringBuilder
> on a null followed by a call to toString returns "".
> 
> you didn't update all the javadoc.  for example:
> 
> >   Index: ToStringStyle.java
> >
===================================================================
> >   RCS file: /home/cvs/jakarta-
>
commons/lang/src/java/org/apache/commons/lang/builder/ToStringStyle.java
,v
> >   retrieving revision 1.29
> >   retrieving revision 1.30
> >   diff -u -r1.29 -r1.30
> >   --- ToStringStyle.java	18 Feb 2004 22:53:24 -0000	1.29
> >   +++ ToStringStyle.java	30 Jun 2004 18:21:49 -0000	1.30
> >   @@ -234,11 +234,13 @@
> >         *  <code>toString</code> for, must not be <code>null</code>
>                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>                        here.
> 
> >         */
> >        public void appendStart(StringBuffer buffer, Object object) {
> >   -        appendClassName(buffer, object);
> >   -        appendIdentityHashCode(buffer, object);
> >   -        appendContentStart(buffer);
> >   -        if (fieldSeparatorAtStart) {
> 
> and shouldn't a new ToStringBuilder on null create the nullText, not
""?
>  --scott
> 
> mustard Milosevic Waihopai early warning Uzi BATF Secretary Justice
> agent Indonesia Marxist non-violent protest MI6 munitions payment
>                          ( http://cscott.net/ )
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message