commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 30334] - [lang] New interface CharacterEncodingNames proposal
Date Tue, 27 Jul 2004 18:24:24 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=30334>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30334

[lang] New interface CharacterEncodingNames proposal





------- Additional Comments From ggregory@seagullsw.com  2004-07-27 18:24 -------
"1) This should be a class, not an interface. Interfaces represent an API to an 
object, not a set of constants. (see SystemUtils)"

Agreed.

"The class name should be changed (it doesn't scan well due to the plural, 
CharacterEncodingNames.UTF_8 kindof implies UTF8 is multiple names."

This second pass calls the class CharacterEncoding and adds one method
isSupported(String). You now read: CharacterEncoding.UTF_8 which is a little better.

"3) I believe that there is a problem with encoding names in some earlier  JDKs, 
where you must use "UTF8" not "UTF-8". I believe all accept the short form."

"UTF-8" works on 1.1.8_10, 1.2.2_017 and 1.3.1_11. Please see the new unit test.
Obviously, the method testMustBeSupportedJava1_3_1 does not pass on <1.3.1. 

"4) Maybe a new class here does make sense if we add methods to it."

I am keeping it as a separate class for now with the method noted above. A
method to "change the encoding" (toEncoding()?) I am not doing yet as I would
like to consider this possibly in the [codec] realm but maybe not. ;-)

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message