Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 50402 invoked from network); 12 Jun 2004 20:48:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 12 Jun 2004 20:48:18 -0000 Received: (qmail 27267 invoked by uid 500); 12 Jun 2004 20:48:16 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 27165 invoked by uid 500); 12 Jun 2004 20:48:15 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 27149 invoked by uid 99); 12 Jun 2004 20:48:15 -0000 Received: from [192.18.33.10] (HELO exchange.sun.com) (192.18.33.10) by apache.org (qpsmtpd/0.27.1) with SMTP; Sat, 12 Jun 2004 13:48:15 -0700 Received: (qmail 4925 invoked by uid 50); 12 Jun 2004 20:49:14 -0000 Date: 12 Jun 2004 20:49:14 -0000 Message-ID: <20040612204914.4924.qmail@nagoya.betaversion.org> From: bugzilla@apache.org To: commons-dev@jakarta.apache.org Cc: Subject: DO NOT REPLY [Bug 29541] New: - EmailValidator allows apostrophes in domain name X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29541 EmailValidator allows apostrophes in domain name Summary: EmailValidator allows apostrophes in domain name Product: Commons Version: 1.1 Final Platform: All OS/Version: All Status: NEW Severity: Major Priority: Other Component: Validator AssignedTo: commons-dev@jakarta.apache.org ReportedBy: mcraig@visiblepath.com JavaMail rejects addresses with apostrophes in the domain name (javax.mail.SendFailedException: 501 Syntax error in recipient address). Here is a patch to reject all domains with apostrophes. -micah Index: src/share/org/apache/commons/validator/EmailValidator.java =================================================================== RCS file: /home/cvspublic/jakarta-commons/validator/src/share/org/apache/commons/validator/EmailValidator.java,v retrieving revision 1.15 diff -u -r1.15 EmailValidator.java --- src/share/org/apache/commons/validator/EmailValidator.java 8 Jun 2004 14:48:35 -0000 1.15 +++ src/share/org/apache/commons/validator/EmailValidator.java 12 Jun 2004 20:26:37 -0000 @@ -187,6 +187,10 @@ * @param domain symbolic domain name */ protected boolean isValidSymbolicDomain(String domain) { + if(domain.indexOf('\'') != -1) { + return false; + } + String[] domainSegment = new String[10]; boolean match = true; int i = 0; Index: src/test/org/apache/commons/validator/EmailTest.java =================================================================== RCS file: /home/cvspublic/jakarta-commons/validator/src/test/org/apache/commons/validator/EmailTest.java,v retrieving revision 1.27 diff -u -r1.27 EmailTest.java --- src/test/org/apache/commons/validator/EmailTest.java 12 Jun 2004 18:18:38 -0000 1.27 +++ src/test/org/apache/commons/validator/EmailTest.java 12 Jun 2004 20:26:37 -0000 @@ -174,9 +174,13 @@ info.setValue("andy.noble@\u008fdata-workshop.com"); valueTest(info, false); - // The ' character is valid in an email address. + // The ' character is valid in an email username. info.setValue("andy.o'reilly@data-workshop.com"); valueTest(info, true); + + // But not in the domain name. + info.setValue("andy@o'reilly.data-workshop.com"); + valueTest(info, false); info.setValue("foo+bar@i.am.not.in.us.example.com"); valueTest(info, true); --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org