Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 40513 invoked from network); 4 Jun 2004 14:21:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 4 Jun 2004 14:21:32 -0000 Received: (qmail 14037 invoked by uid 500); 4 Jun 2004 14:21:31 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 13989 invoked by uid 500); 4 Jun 2004 14:21:30 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 13974 invoked by uid 500); 4 Jun 2004 14:21:30 -0000 Received: (qmail 13970 invoked by uid 99); 4 Jun 2004 14:21:29 -0000 Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.27.1) with SMTP; Fri, 04 Jun 2004 07:21:29 -0700 Received: (qmail 14048 invoked by uid 1674); 4 Jun 2004 13:53:12 -0000 Date: 4 Jun 2004 13:53:12 -0000 Message-ID: <20040604135312.14047.qmail@minotaur.apache.org> From: mdiggory@apache.org To: jakarta-commons-cvs@apache.org Subject: cvs commit: jakarta-commons/math/src/test/org/apache/commons/math/stat/data CertifiedDataAbstractTest.java X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N mdiggory 2004/06/04 06:53:12 Modified: math/src/test/org/apache/commons/math/stat/data CertifiedDataAbstractTest.java Log: This call to StringUtils did very little for the following conditional structure. Consolidated code and removed dependency on lang. Revision Changes Path 1.5 +9 -9 jakarta-commons/math/src/test/org/apache/commons/math/stat/data/CertifiedDataAbstractTest.java Index: CertifiedDataAbstractTest.java =================================================================== RCS file: /home/cvs/jakarta-commons/math/src/test/org/apache/commons/math/stat/data/CertifiedDataAbstractTest.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- CertifiedDataAbstractTest.java 1 Jun 2004 23:40:29 -0000 1.4 +++ CertifiedDataAbstractTest.java 4 Jun 2004 13:53:12 -0000 1.5 @@ -27,8 +27,6 @@ import java.util.Iterator; import java.util.Map; -//import org.apache.commons.beanutils.PropertyUtils; -import org.apache.commons.lang.StringUtils; import org.apache.commons.math.TestUtils; import org.apache.commons.math.stat.univariate.DescriptiveStatistics; import org.apache.commons.math.stat.univariate.SummaryStatistics; @@ -63,12 +61,14 @@ String line = in.readLine(); while (line != null) { - line = StringUtils.trimToNull(line); - if (line == null) { - // empty line - } else if (line.startsWith("#")) { - // comment - } else { + + /* this call to StringUtils did little for the + * following conditional structure + */ + line = line.trim(); + + // not empty line or comment + if (!("".equals(line) || line.startsWith("#"))) { int n = line.indexOf('='); if (n == -1) { // data value --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org