Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 66054 invoked from network); 1 Jun 2004 22:55:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 1 Jun 2004 22:55:24 -0000 Received: (qmail 53688 invoked by uid 500); 1 Jun 2004 22:55:37 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 53487 invoked by uid 500); 1 Jun 2004 22:55:36 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 53467 invoked by uid 500); 1 Jun 2004 22:55:36 -0000 Received: (qmail 53443 invoked by uid 99); 1 Jun 2004 22:55:35 -0000 Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.27.1) with SMTP; Tue, 01 Jun 2004 15:55:35 -0700 Received: (qmail 65992 invoked by uid 1529); 1 Jun 2004 22:55:14 -0000 Date: 1 Jun 2004 22:55:14 -0000 Message-ID: <20040601225514.65991.qmail@minotaur.apache.org> From: scolebourne@apache.org To: jakarta-commons-cvs@apache.org Subject: cvs commit: jakarta-commons/collections/src/test/org/apache/commons/collections/collection AbstractTestCollection.java X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N scolebourne 2004/06/01 15:55:14 Modified: collections/src/test/org/apache/commons/collections AbstractTestObject.java collections/src/test/org/apache/commons/collections/collection AbstractTestCollection.java Log: Add isEqualsCheckable and fix testSerializeDeserializeThenCompare in AbstractTestObject Revision Changes Path 1.7 +12 -2 jakarta-commons/collections/src/test/org/apache/commons/collections/AbstractTestObject.java Index: AbstractTestObject.java =================================================================== RCS file: /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/AbstractTestObject.java,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- AbstractTestObject.java 31 May 2004 22:39:20 -0000 1.6 +++ AbstractTestObject.java 1 Jun 2004 22:55:14 -0000 1.7 @@ -95,6 +95,14 @@ return true; } + /** + * Returns true to indicate that the collection supports equals() comparisons. + * This implementation returns true; + */ + public boolean isEqualsCheckable() { + return true; + } + //----------------------------------------------------------------------- public void testObjectEqualsSelf() { Object obj = makeObject(); @@ -140,7 +148,9 @@ ObjectInputStream in = new ObjectInputStream(new ByteArrayInputStream(buffer.toByteArray())); Object dest = in.readObject(); in.close(); - assertEquals("obj != deserialize(serialize(obj))", obj, dest); + if (isEqualsCheckable()) { + assertEquals("obj != deserialize(serialize(obj))", obj, dest); + } } } 1.8 +2 -2 jakarta-commons/collections/src/test/org/apache/commons/collections/collection/AbstractTestCollection.java Index: AbstractTestCollection.java =================================================================== RCS file: /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/collection/AbstractTestCollection.java,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- AbstractTestCollection.java 31 May 2004 22:39:20 -0000 1.7 +++ AbstractTestCollection.java 1 Jun 2004 22:55:14 -0000 1.8 @@ -230,7 +230,7 @@ /** * Returns true to indicate that the collection supports equals() comparisons. - * The default implementation returns false; + * This implementation returns false; */ public boolean isEqualsCheckable() { return false; --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org