commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mdigg...@apache.org
Subject cvs commit: jakarta-commons/math/src/test/org/apache/commons/math/stat/data CertifiedDataAbstractTest.java
Date Fri, 04 Jun 2004 13:53:12 GMT
mdiggory    2004/06/04 06:53:12

  Modified:    math/src/test/org/apache/commons/math/stat/data
                        CertifiedDataAbstractTest.java
  Log:
  This call to StringUtils did very little for the following conditional structure. Consolidated
code and removed dependency on lang.
  
  Revision  Changes    Path
  1.5       +9 -9      jakarta-commons/math/src/test/org/apache/commons/math/stat/data/CertifiedDataAbstractTest.java
  
  Index: CertifiedDataAbstractTest.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/math/src/test/org/apache/commons/math/stat/data/CertifiedDataAbstractTest.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- CertifiedDataAbstractTest.java	1 Jun 2004 23:40:29 -0000	1.4
  +++ CertifiedDataAbstractTest.java	4 Jun 2004 13:53:12 -0000	1.5
  @@ -27,8 +27,6 @@
   import java.util.Iterator;
   import java.util.Map;
   
  -//import org.apache.commons.beanutils.PropertyUtils;
  -import org.apache.commons.lang.StringUtils;
   import org.apache.commons.math.TestUtils;
   import org.apache.commons.math.stat.univariate.DescriptiveStatistics;
   import org.apache.commons.math.stat.univariate.SummaryStatistics;
  @@ -63,12 +61,14 @@
   			
   			String line = in.readLine();
   			while (line != null) {
  -				line = StringUtils.trimToNull(line);
  -				if (line == null) {
  -					// empty line
  -				} else if (line.startsWith("#")) {
  -					// comment
  -				} else {
  +			    
  +			    /* this call to StringUtils did little for the 
  +			     * following conditional structure 
  +			     */
  +			    line = line.trim();
  +
  +				// not empty line or comment
  +				if (!("".equals(line) || line.startsWith("#"))) {
   					int n = line.indexOf('=');
   					if (n == -1) {
   						// data value
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message