commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 29294] - [lang][PATCH] lang.math.Fraction class deficiencies
Date Thu, 03 Jun 2004 20:18:23 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=29294>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29294

[lang][PATCH] lang.math.Fraction class deficiencies





------- Additional Comments From cananian@alumni.princeton.edu  2004-06-03 20:18 -------
My response to Stephen's comments (slightly edited for brevity):

From: C. Scott Ananian

On Thu, 3 Jun 2004, Stephen Colebourne wrote:
                                                                                
> I had a 5 second look yesterday, and realised how big the change is. My
> immediate concern is that the Fraction class has lost its final status,
> making it less immutable.
                                                                                
The idea is to remove the deprecated methods in some future version of
lang; at which point Fraction can be made final again (and BadFraction
completely disappears).  It would be harder to purge BadFraction if its
code is mixed willy-nilly with the 'real' Fraction code.
                                                                                
The constructor for Fraction is package-private (or should be!) so no one
outside the lang package can create a subclass in any case.

> Also, I wasn't sure what 'relatively prime' actually meant. Its probably too
> mathematical for the target audience in [lang].
                                                                                
Formal definition: http://mathworld.wolfram.com/RelativelyPrime.html

It just means that there is no integer greater than one which divides both
numbers evenly (gcd(x,y)==1), or (equivalently) that the fraction is
"simplified".  I'll be glad to add that to the javadoc.
                                                                                
> Finally, I believe that [lang] is the right place for these (including
> BigFraction). They represent missing parts of the JDK, so [lang] is
> appropriate.
                                                                                
ok.
 --scott

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message