commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne" <scolebou...@btopenworld.com>
Subject Re: [lang] [math] org.apache.commons.lang.math.Fraction class
Date Wed, 02 Jun 2004 23:37:17 GMT
I had a 5 second look yesterday, and realised how big the change is. My
immediate concern is that the Fraction class has lost its final status,
making it less immutable.

I was wondering whether it would be possible to have just one class (rather
than an additional BadFraction subclass) that held an additional field only
used when using non-reduced fractions. Effectively merging the two classes
into one?

Also, I wasn't sure what 'relatively prime' actually meant. Its probably too
mathematical for the target audience in [lang].

Finally, I believe that [lang] is the right place for these (including
BigFraction). They represent missing parts of the JDK, so [lang] is
appropriate.

Stephen

----- Original Message -----
From: "C. Scott Ananian" <cscott@cscott.net>
> > > What about getNumerator()/getDenominator() - won't these change if 2/4
is
> > > held differently? I believe that we need to preserve the 2/4 concept
> > > distinct from 1/2, at least in the [lang] version.
>
> All these concerns have been addressed in the latest version of my patch.
> I'd appreciate review and comments.  Thanks!
>  http://issues.apache.org/bugzilla/show_bug.cgi?id=29294
>   --scott
>
> overthrow Echelon justice plastique ASW Yeltsin Sigint assassination
> early warning Soviet  Bush Cocaine terrorist Legion of Doom ammunition
>                          ( http://cscott.net/ )


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message