Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 63189 invoked from network); 1 May 2004 12:54:36 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 1 May 2004 12:54:36 -0000 Received: (qmail 28828 invoked by uid 500); 1 May 2004 12:54:30 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 28742 invoked by uid 500); 1 May 2004 12:54:29 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 28727 invoked by uid 500); 1 May 2004 12:54:29 -0000 Received: (qmail 28724 invoked from network); 1 May 2004 12:54:29 -0000 Received: from unknown (HELO minotaur.apache.org) (209.237.227.194) by daedalus.apache.org with SMTP; 1 May 2004 12:54:29 -0000 Received: (qmail 63136 invoked by uid 1340); 1 May 2004 12:54:32 -0000 Date: 1 May 2004 12:54:32 -0000 Message-ID: <20040501125432.63135.qmail@minotaur.apache.org> From: dirkv@apache.org To: jakarta-commons-cvs@apache.org Subject: cvs commit: jakarta-commons/dbcp/src/test/org/apache/commons/dbcp TestBasicDataSource.java X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N dirkv 2004/05/01 05:54:32 Modified: dbcp/src/test/org/apache/commons/dbcp TestBasicDataSource.java Log: Bugzilla Bug 28251: Returning dead database connections to BasicDataSource - JUnit test Revision Changes Path 1.18 +23 -1 jakarta-commons/dbcp/src/test/org/apache/commons/dbcp/TestBasicDataSource.java Index: TestBasicDataSource.java =================================================================== RCS file: /home/cvs/jakarta-commons/dbcp/src/test/org/apache/commons/dbcp/TestBasicDataSource.java,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- TestBasicDataSource.java 28 Feb 2004 11:47:51 -0000 1.17 +++ TestBasicDataSource.java 1 May 2004 12:54:32 -0000 1.18 @@ -16,6 +16,7 @@ package org.apache.commons.dbcp; +import java.io.IOException; import java.sql.Connection; import java.sql.SQLException; @@ -225,5 +226,26 @@ assertEquals(0, ds.getNumActive()); assertEquals(10, ds.getNumIdle()); + } + + // Bugzilla Bug 28251: Returning dead database connections to BasicDataSource + // isClosed() failure blocks returning a connection to the pool + public void testIsClosedFailure() throws SQLException { + ds.setAccessToUnderlyingConnectionAllowed(true); + Connection conn = ds.getConnection(); + assertNotNull(conn); + assertEquals(1, ds.getNumActive()); + + // set an IO failure causing the isClosed mathod to fail + TesterConnection tconn = (TesterConnection) ((DelegatingConnection)conn).getInnermostDelegate(); + tconn.setFailure(new IOException("network error")); + + try { + conn.close(); + fail("Expected SQLException"); + } + catch(SQLException ex) { } + + assertEquals(0, ds.getNumActive()); } } --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org