Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 14939 invoked from network); 6 Apr 2004 02:29:22 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 6 Apr 2004 02:29:22 -0000 Received: (qmail 46927 invoked by uid 500); 6 Apr 2004 02:29:00 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 46862 invoked by uid 500); 6 Apr 2004 02:28:59 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 46838 invoked from network); 6 Apr 2004 02:28:59 -0000 Received: from unknown (HELO mail1.speakeasy.net) (216.254.0.201) by daedalus.apache.org with SMTP; 6 Apr 2004 02:28:59 -0000 Received: (qmail 30505 invoked from network); 6 Apr 2004 02:29:08 -0000 Received: from dsl092-162-013.wdc2.dsl.speakeasy.net (HELO apache.org) (leland@[66.92.162.13]) (envelope-sender ) by mail1.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 6 Apr 2004 02:29:08 -0000 Message-ID: <407215AC.6000406@apache.org> Date: Mon, 05 Apr 2004 22:27:56 -0400 From: Robert Leland User-Agent: Mozilla Thunderbird 0.5 (Windows/20040207) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jakarta Commons Developers List Subject: Re: [Validator] Url Validation Patch - [Bug 28190] References: <021101c41b75$6a87ba20$a8ad2b52@DELL1800> <407213FC.3020206@apache.org> In-Reply-To: <407213FC.3020206@apache.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Robert Leland wrote: > Niall Pemberton wrote: > >> Any feedback on the patch I submitted adding the ability to return an >> error code from when validating Url's? >> >> http://issues.apache.org/bugzilla/show_bug.cgi?id=28190 >> >> >> Niall >> >> >> > I have a deadline this Friday that will probably stretch over the > weekend. > After that I'll have a chance to review it. Looking at it briefly, the > patch itself looks ok. > The main items I would look at is how it fits in with the other > validations and if there was > any mechanism that might be generalized to keep the validations > consistent. > > -Rob I am inclined to simplify the code and always return the expandedCode, that would make the control flow simpler. --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org