commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Leland <rlel...@apache.org>
Subject Re: [Validator] Url Validation Patch - [Bug 28190]
Date Tue, 06 Apr 2004 02:27:56 GMT
Robert Leland wrote:

> Niall Pemberton wrote:
>
>> Any feedback on the patch I submitted adding the ability to return an 
>> error code from when validating Url's?
>>
>>  http://issues.apache.org/bugzilla/show_bug.cgi?id=28190
>>
>>
>> Niall
>>
>>  
>>
> I have a deadline this Friday that will probably stretch over the 
> weekend.
> After that I'll have a chance to review it. Looking at it briefly, the 
> patch itself looks ok.
> The main items I would look at is how it fits in with the other 
> validations and if there was
> any mechanism that might be generalized to keep the validations 
> consistent.
>
> -Rob 

I am inclined to simplify the code and always return the expandedCode, 
that would make the control flow simpler.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message