Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: [lang] CharUtils.isAscii methods and CharSet, two issues
Date: Wed, 10 Mar 2004 19:41:55 -0500
Message-ID: <D1639D06CFBD014F87F3978DA7038B933F9EB1@ns1017.SSSI.seagull.nl>
Thread-Topic: [lang] CharUtils.isAscii methods and CharSet, two issues
Thread-Index: AcQGuIQJBvhjQwHjQZC2D8QCgiPUJwARzk3g
From: "Gary Gregory" <ggregory@seagullsw.com>
To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>

Hello,

Looking at the new CharUtils class and its isAscii methods and the
CharSet class, something feels slightly off.

(1)
The first thing is that the isAscii* could be implemented in terms of
already existing CharSet code.=20

For example, in CharUtils:

    public static boolean isAsciiAlphaUpper(char ch) {
        return (ch >=3D 'A' && ch <=3D 'Z');
    }

Eating our own dog food:

    public static boolean isAsciiAlphaUpper(char ch) {
        return CharSet.ASCII_ALPHA_UPPER.contains(ch);
    }

(2)
The second item that I am wondering about is the introduction of methods
like is{Encoding}SomeCondition(char). This is believe is not OO. One
should ask the question to some encoding object, which is what CharSet
looks to be for.

Would it make sense to improve CharSet with these condition methods such
that one could write:

CharSet.ASCII.isAlphaUpper(ch)
CharSet.ASCII.isWhatever(ch)

?

Thank you,
Gary


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org