Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 69106 invoked from network); 8 Mar 2004 00:48:21 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 8 Mar 2004 00:48:21 -0000 Received: (qmail 10359 invoked by uid 500); 8 Mar 2004 00:47:54 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 10247 invoked by uid 500); 8 Mar 2004 00:47:54 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 10195 invoked from network); 8 Mar 2004 00:47:53 -0000 Received: from unknown (HELO exchange.sun.com) (192.18.33.10) by daedalus.apache.org with SMTP; 8 Mar 2004 00:47:53 -0000 Received: (qmail 4644 invoked by uid 50); 8 Mar 2004 00:48:29 -0000 Date: 8 Mar 2004 00:48:29 -0000 Message-ID: <20040308004829.4643.qmail@nagoya.betaversion.org> From: bugzilla@apache.org To: commons-dev@jakarta.apache.org Cc: Subject: DO NOT REPLY [Bug 20813] - [FileUpload] does not take 'charset' parameter of the 'Content-Type' header into consideration X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20813 [FileUpload] does not take 'charset' parameter of the 'Content-Type' header into consideration ------- Additional Comments From martinc@apache.org 2004-03-08 00:48 ------- OK, I've looked at "take 3", and if you're willing to make a few changes, I'll commit a "take 4". 1) The new classes need to have the 2.0 license applied, since the rest of FileUpload has been updated to the new license. 2) All of the code needs to abide by the Turbine coding guidelines. (Checkstyle will verify this for you.) The mods to existing classes are OK in this regard, but the new classes appear to use the Sun coding guidelines. 3) The Javadocs for all methods need to include documentation for the parameters and return values. --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org