commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <p...@steitz.com>
Subject Re: [id] use of commons-logging
Date Sun, 14 Mar 2004 14:22:33 GMT
Tim Reilly wrote:
> Since there is a dependency on commons-logging; any issues with using it?
> 
> For example in IdentifierGeneratorFactory.java line 53
> 
> -        } catch (Exception ex) {
> -            // ignore as default implementation will be used.
> +        }
> +        catch (Exception ex) {
> +            if (log.isInfoEnabled()) {
> +                log.info(ex);
> +            }
> 
> There are two other similar places in the uuid packages I was think it might
> be useful to log what's happening in the recoverable exceptions.
> 
I would be -1 to the change above, since the "no configuration present, so 
use default" situation is not really exceptional.  I would be careful 
adding logging elsewhere if there is any chance that it will end up 
generating a large volume of log messages under normal circumstances.

Phil
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message