commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Cooper <mart...@apache.org>
Subject Re: [Validator] Unit tests failing
Date Tue, 30 Mar 2004 05:02:45 GMT
On Mon, 29 Mar 2004, David Graham wrote:

>
> --- Martin Cooper <martinc@apache.org> wrote:
> > On Mon, 29 Mar 2004, David Graham wrote:
> >
> > >
> > > --- Martin Cooper <martinc@apache.org> wrote:
> > > > On Mon, 29 Mar 2004, rleland@apache.org wrote:
> > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Martin Cooper [mailto:martinc@apache.org]>
> > > > > > I have a bit of trouble with "supposed to fail". Perhaps
> > "currently
> > > > > > expected to fail"? ;-)
> > > > > >
> > > > > > In any case, I'm not comfortable with rolling a release where
> > 'maven
> > > > clean
> > > > > > dist' fails right out of the box. Can we disable the failing
> > tests
> > > > for
> > > > > > now, with a comment explaining why?
> > > > >
> > > > > A Maven(rc1) clean dist works for me, and the site generates
> > cleanly.
> > > > >
> > > > > So I can disable the failing tests which target are you using
> > besides
> > > > > maven clean dist, which works for me.
> > > >
> > > > Hmm, that's odd. The error report I attached earlier in this thread
> > was
> > > > the result of 'maven clean dist' on Validator HEAD with Maven
> > 1.0-rc1. I
> > > > don't have the ability to re-run that until I get home this evening,
> > but
> > > > I can't see how that would work for you but not for me...
> > >
> > > Maven 1.0 RC1 'maven clean dist' didn't work for me this weekend
> > either.
> > > The site generates fine because test failures don't stop that target.
> > > There should be a commented line in project.properties that will
> > disable
> > > the tests and another line that will allow the dist target to continue
> > > despite test failures.
> >
> > I was thinking more along the lines of renaming the specific test
> > methods
> > that fail (e.g. by prepending "DISABLE" so that JUnit won't pick them
> > up). That way,  the remainder of the tests can run, rather than
> > disabling
> > all unit tests.
>
> I just committed a change that disables the 2 failing tests with FIXME
> reminders to come back to them later.  All tests now pass and 'maven clean
> dist' works.

Thanks, David. That did the trick.

--
Martin Cooper


> David
>
> > Martin Cooper
>
>
> __________________________________
> Do you Yahoo!?
> Yahoo! Finance Tax Center - File online. File on time.
> http://taxes.yahoo.com/filing.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message