commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 20813] - [FileUpload] does not take 'charset' parameter of the 'Content-Type' header into consideration
Date Sun, 07 Mar 2004 17:01:09 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20813>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20813

[FileUpload] does not take 'charset' parameter of the 'Content-Type' header into consideration





------- Additional Comments From olegk@apache.org  2004-03-07 17:01 -------
> * I am not willing to commit a patch for this issue without an accompanying 
> unit test. The issue, as I understand it, does not arise with current browsers, 
> so without a unit test, I would be "driving blind".

Martin,
I doubt you had taken even a cursory look at the patch. Had you done so, you
might have noticed that there had been accompanying test cases since the very
first submission. If you think that some test cases are missing or certain
functionality is not adequately covered with the existing test cases, I'll be
more than willing to provide the missing bits


> * The fact that you are at "take 3" on a patch for this emphasises the need for 
> unit tests, and suggests that the solution is not yet fully worked out.

This is a very interesting observation. Actually the patch has been ignored for
so long (over 8 months) that I found enough time to do some object allocation
and performance optimization on the parameter parser, hence take 2. Besides,
this patch is pretty much a code donation from the [HttpClient] project where
the parameter parser has been around ever since the initial patch submission. 

If you see some flaws in implementation, feel free to point them out, and I'll
happily do my best to correct them. Feel free to reject the patch altogether if
you see fundamental design flaws, but try to be a bit more specific than "the
solution is not yet fully worked out". I am a big boy, rejection of this patch
will not make my world end. 

Moreover, if you find attempts to make [FileUpload] a little friendlier to
non-English speaking folks "annoying", do say so. I'll never bother you again

Kind regards,

Oleg

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message