commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Kitching <si...@ecnetwork.co.nz>
Subject Re: [digester] plugins patch - how best to post for review?
Date Sun, 28 Mar 2004 04:18:21 GMT
On Sat, 2004-03-27 at 09:45, Craig R. McClanahan wrote:
> Quoting Simon Kitching <simon@ecnetwork.co.nz>:
> 
> > Hi,
> > 
> > I've got a significant patch ready for Digester's plugins module.
> > 
> > It refactors the existing code that currently locates the dynamic rules
> > for a plugin into a Strategy pattern with a number of predefined
> > strategies matching the old code.
> > 
> > The patch also fixes a number of outstanding issues, particularly to do
> > with hard-wired xml attribute names.
> > 
> > I'm wondering what the best thing to do with all this is.

> Your best bet would be a branch, not just a tag.  That way, you can do the
> development in parallel on your branch, and we can (if we like it at the end)
> merge into the HEAD when we're satisfied.  Robert is doing something similar on
> Betwixt.
> 
> As for a name, something like "DIGESTER_PLUGIN_REFACTORING_BRANCH" or something
> would be good -- it includes both the name of the component the branch is for
> (since we all share the same repository) and makes it clear that this is a
> branch tag, not just a marker tag.

Ok. I've never used CVS branches before, but I'm willing to give it a
shot.

Should I tag the whole digester repository with this branch-tag, or just
the 
   src/java/org/apache/commons/digester/plugins and
   src/test/org/apache/commons/digester/plugins
subdirectories that are affected?

Regards,

Simon



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message