commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertburrelldon...@blueyonder.co.uk>
Subject [logging] improved exception diagnostics [WAS Re: [logging] work needed for 1.0.4]
Date Sun, 29 Feb 2004 10:04:50 GMT
(new thread to discuss these issues.)

On 28 Feb 2004, at 19:37, Dennis Lundberg wrote:

> #25156 [logging] Enhance error message for 
> "org.apache.commons.logging.impl.Log4JLogger does not implement Log"
> - This seems to me to be similar to #26598
>
> #26598 [logging] org.apache.commons.logging.impl.LogFactoryImpl does 
> not provide enough information on an InvocationTargetException in the 
> newInstance() method.
> - This is something that has to be decided on. It involves catching an 
> extra Exception to provide a better error-message. Code that shows how 
> to do it is available in the bugreport.

these are about making it easier for people to work out what's gone 
wrong when a LogConfigurationException is thrown. at the moment, all 
throwables are caught and rethrown as LogConfigurationException's. this 
includes InvocationTargetException's. (see 
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26598)

i think it's important to understand that any change in this area would 
probably result in a change in exception handling symantics. any code 
that processed LogConfigurationException's by using getCause may be 
effected by a change in this area.

the requests for changes seem (to me) to be focussed mainly on improved 
diagnostics (more meaningful stack traces and messages). we may be able 
to retain the older symantics by changing LogConfigurationException so 
that it extracts the target exception and uses that for stack traces 
and to create the message but still sets the internal cause as it does 
now.

comments, anyone?

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message