commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertburrelldon...@blueyonder.co.uk>
Subject Re: [BeanUtils] WrapDynaBean Enhacement Request
Date Tue, 06 Jan 2004 20:32:15 GMT
hi niall

patches are much more likely to get promptly applied if they come with 
unit tests (hint, hint ;)

1+2 it seemed clear that craig intended no constructors to be available 
(and he usually has good reasons for his design decisions) but i think 
that allowing WrapDynaClass and WrapDynaBean to fit better into 
DynaBean frameworks seems like a strong argument for providing this 
functionality. unless someone else speaks up, i'll likely commit 
something along these lines.

3 seems to me to be a symptom of a bigger issue (which has been known 
for some time). the exception handling in beanutils is painful and 
confusing to many users. i'd be very reluctant to break backwards 
compatibility (even for symantics) and i suspect that the proposed 
patch does. we've talked before about the possibility of factoring out 
the exception handling and possible it might be better to fix this 
rather than the symptom.  so maybe a little more talk and thought is 
needed about this one.

comments welcome

- robert

On 6 Jan 2004, at 00:17, Niall Pemberton wrote:

> Thanks, feedback would be much appreciated.
>
> Niall
> ----- Original Message -----
> From: "robert burrell donkin" <robertburrelldonkin@blueyonder.co.uk>
> To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
> Sent: Monday, January 05, 2004 10:44 PM
> Subject: Re: [BeanUtils] WrapDynaBean Enhacement Request
>
>
>> hi niall
>>
>> i'll take a look at this sometime soonish.
>>
>> - robert
>>
>> On 30 Dec 2003, at 13:14, Niall Pemberton wrote:
>>
>>> I submitted a bugzilla a while ago to enhace
>>> WrapDynaBean/WrapDynaClass:
>>>
>>> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23690
>>>
>>>
>>> The changes were
>>>
>>> 1) Implement a getInstance() method in WrapDynaBean so that the
>>> "original" wrapped bean can be retrieved.
>>> 2) Implement a newInstance() method in WrapDynaClass to generate new
>>> "wrapped" beans.
>>> 3) Change the get(name) and set(name, value) methods to make them 
>>> more
>>> efficient and provide more usefull exception messages.
>>>
>>>
>>> Is there any chance on getting some feedback and/or indication 
>>> whether
>>> there is any interest in applying it?
>>>
>>> Thanks
>>>
>>> Niall
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message