commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Horsman <B...@logicalcobwebs.co.uk>
Subject Re: [PATCH] Re: [jexl] - checking for unresolved variables
Date Sun, 11 Jan 2004 20:03:24 GMT
On Sun, 2004-01-11 at 20:47, peter royal wrote:

> Looks good. My only suggestion is that you likely want to check for 
> existence of the key in the map in order to known when to throw the 
> exception, as opposed to testing for null. That way you can have valid 
> variables that are null.

Argh, you're right. To be honest, I'd forgotten that a map's value could
be null. I've made the change as you suggest and changed the unit test
to use a null value and it passes.

Do you want me to resubmit the patch? BTW, my patch file didn't include
the new file I added. Is there anyway of including the new files too, or
do I just need to include them separately?

-
Bill


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message