Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 66852 invoked from network); 15 Dec 2003 02:08:51 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 15 Dec 2003 02:08:51 -0000 Received: (qmail 96085 invoked by uid 500); 15 Dec 2003 02:08:32 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 95860 invoked by uid 500); 15 Dec 2003 02:08:31 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 95844 invoked from network); 15 Dec 2003 02:08:31 -0000 Received: from unknown (HELO pintail.mail.pas.earthlink.net) (207.217.120.122) by daedalus.apache.org with SMTP; 15 Dec 2003 02:08:31 -0000 Received: from h-66-167-117-244.sndacagl.dynamic.covad.net ([66.167.117.244] helo=localhost.localdomain) by pintail.mail.pas.earthlink.net with esmtp (Exim 3.33 #1) id 1AViA3-0005yd-00 for commons-dev@jakarta.apache.org; Sun, 14 Dec 2003 18:08:39 -0800 Received: from phreaker.net (terrordome [127.0.0.1]) by localhost.localdomain (8.11.6/8.11.6) with ESMTP id hBF26wF05163 for ; Sun, 14 Dec 2003 18:06:58 -0800 Message-ID: <3FDD1741.8060904@phreaker.net> Date: Sun, 14 Dec 2003 18:06:57 -0800 From: __matthewHawthorne User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jakarta Commons Developers List Subject: Re: [lang] JUnit version, broken tests References: <3FDB7A7C.8070904@steitz.com> <006601c3c1c3$cc9b0200$9d448051@oemcomputer> <3FDCF818.7040403@steitz.com> <3FDCFAAC.1060609@phreaker.net> <3FDD12F6.4080005@steitz.com> In-Reply-To: <3FDD12F6.4080005@steitz.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Phil Steitz wrote: > __matthewHawthorne wrote: > >> Instead of removing it, is it possible to modify the test to "expect" >> the failure? I'm not familiar with the test or class that you're >> speaking of, but sometimes it's nice to keep tests like this around. >> >> Maybe catch an expected RuntimeException, or change an assertTrue to >> an assertFalse, etc.? >> >> > The problem is that the test case testNestedBroken in > o.a.c.l.enum.EnumTest is expecting "broken" behavior which does not > occur under (Sun Linux) jdk 1.4.2. There is not much else in the test > case. That's why I suggested removing it. > > Phil Ah, now I understand. Since it's such a specific test, you're probably right, it makes sense to remove it. Either that, or perhaps you could use SystemUtils to only run the test if it's on the expected version and platform. --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org