Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 23125 invoked from network); 15 Dec 2003 00:06:54 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 15 Dec 2003 00:06:54 -0000 Received: (qmail 28770 invoked by uid 500); 15 Dec 2003 00:06:38 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 28403 invoked by uid 500); 15 Dec 2003 00:06:36 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 28384 invoked from network); 15 Dec 2003 00:06:35 -0000 Received: from unknown (HELO falcon.mail.pas.earthlink.net) (207.217.120.74) by daedalus.apache.org with SMTP; 15 Dec 2003 00:06:35 -0000 Received: from h-66-167-117-244.sndacagl.dynamic.covad.net ([66.167.117.244] helo=localhost.localdomain) by falcon.mail.pas.earthlink.net with esmtp (Exim 3.33 #1) id 1AVgG3-0005BF-00 for commons-dev@jakarta.apache.org; Sun, 14 Dec 2003 16:06:43 -0800 Received: from phreaker.net (terrordome [127.0.0.1]) by localhost.localdomain (8.11.6/8.11.6) with ESMTP id hBF051F04667 for ; Sun, 14 Dec 2003 16:05:01 -0800 Message-ID: <3FDCFAAC.1060609@phreaker.net> Date: Sun, 14 Dec 2003 16:05:00 -0800 From: __matthewHawthorne User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jakarta Commons Developers List Subject: Re: [lang] JUnit version, broken tests References: <3FDB7A7C.8070904@steitz.com> <006601c3c1c3$cc9b0200$9d448051@oemcomputer> <3FDCF818.7040403@steitz.com> In-Reply-To: <3FDCF818.7040403@steitz.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Instead of removing it, is it possible to modify the test to "expect" the failure? I'm not familiar with the test or class that you're speaking of, but sometimes it's nice to keep tests like this around. Maybe catch an expected RuntimeException, or change an assertTrue to an assertFalse, etc.? Phil Steitz wrote: > Stephen Colebourne wrote: > >> +1, enough time has now passed for JUnit3.8 to be OK >> >> Stephen > > > Done. The enum test remains broken, however under JDK 1.4.2. > > The test that is failing was added to demonstrate the problem referenced > in PR 23374. Since it fails (actually just fails to demonstrate > "broken" behavior) under 1.4.2, I would like to remove it. Any > objections to this? > > Phil > >> >> ----- Original Message ----- >> From: "Phil Steitz" >> To: "Jakarta Commons Developers List" >> Sent: Saturday, December 13, 2003 8:45 PM >> Subject: [lang] JUnit version, broken tests >> >> >> >>> Some tests (/builder/ShortPrefixToStringStyleTest, ArrayUtils.Test) have >>> been been added/modified to require Junit 3.8. I have no problem with >>> this; but we need to modify the dependency in project.xml for the maven >>> build to work in this case. Any objections to this change? >>> >>> I am seeing the following failure in the builder tests: >>> >>> Testcase: testNestedBroken took 0.006 sec >>> FAILED >>> expected:<0> but was:<3> >>> junit.framework.AssertionFailedError: expected:<0> but was:<3> >>> at >> >> >> org.apache.commons.lang.enum.EnumTest.testNestedBroken(EnumTest.java:432) >> >>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>> at >>> >> >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39 >> >> ) >> >>> at >>> >> >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl >> >> .java:25) >> >>> I am using Sun Linux JDK 1.4.2 >>> >>> Phil >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org >>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org >>> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org >> For additional commands, e-mail: commons-dev-help@jakarta.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org