Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Content-Type: text/plain;
  charset="us-ascii"
From: steve cohen <scohen@javactivity.org>
To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Subject: [NET] VMSFTPEntryParser bug?
Date: Mon, 29 Dec 2003 16:27:50 -0600
User-Agent: KMail/1.4.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-Id: <200312291627.50731.scohen@javactivity.org>

I am trying to build commons-net prior to making some changes and some other 
issues have come to light.

One of the tests is failing for me - 
VMSFTPEntryParserTest.testParseFileList().  

This test seems poorly implemented, since the class being tested builds its 
list of files using a HashMap to eliminate dupes, I presume, and then spits 
out the list by calling values() on the HashMap - which spits out the values 
in an order that is different from the one the test is expecting.  I was 
running this under java 1.3 on linux.  I switched to java 1.4 and it is also 
failing but on a different line.  I'm not sure what platform Jeff is on when 
he did the build, but I think I should rewrite this test in a way that 
doesn't assume any particular order since this seems to be JDK-implementation 
dependent.  The JavaDoc for HashMap specifies no order that should be 
expected for HashMap.values(), nor for HashMap.keySet() for that matter.  We 
could probably achieve a dependable order by using a TreeMap.keySet() 
instead.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org