Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 95789 invoked from network); 11 Nov 2003 21:54:33 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 11 Nov 2003 21:54:33 -0000 Received: (qmail 80334 invoked by uid 500); 11 Nov 2003 21:54:18 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 80289 invoked by uid 500); 11 Nov 2003 21:54:17 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 80273 invoked from network); 11 Nov 2003 21:54:17 -0000 Received: from unknown (HELO smtp-out6.blueyonder.co.uk) (195.188.213.9) by daedalus.apache.org with SMTP; 11 Nov 2003 21:54:17 -0000 Received: from [10.0.0.2] ([82.38.66.131]) by smtp-out6.blueyonder.co.uk with Microsoft SMTPSVC(5.0.2195.5600); Tue, 11 Nov 2003 21:54:24 +0000 Mime-Version: 1.0 (Apple Message framework v606) In-Reply-To: <1068586743.3fb156f729059@localhost> References: <20031111182416.3959.qmail@nagoya.betaversion.org> <3FB12D03.3010505@apache.org> <3FB14FF5.7000309@apache.org> <1068586743.3fb156f729059@localhost> Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: robert burrell donkin Subject: Re: [digester] [PATCH] Adding Ant-like properties support Date: Tue, 11 Nov 2003 21:56:49 +0000 To: "Jakarta Commons Developers List" X-Mailer: Apple Mail (2.606) X-OriginalArrivalTime: 11 Nov 2003 21:54:24.0554 (UTC) FILETIME=[5ED0B0A0:01C3A89E] X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N On 11 Nov 2003, at 21:39, Craig R. McClanahan wrote: > Quoting Remy Maucherat : > >> Remy Maucherat wrote: >> >>> Hi, >>> >>> I described the feature a couple weeks ago, and here's my patch. >>> >>> It currently only replaces attributes processed by the setProperties >>> rule. This did sound good enough to me. I read about processing text >>> nodes too (does Ant do this also ?), so maybe we can improve this >>> patch/feature more. >> >> BTW, I do have commit access on digester, so I can commit it myself if >> the change is acceptable (for a first implementation). >> >> Remy >> > > At first glance it looks fine ... I will have a little time this > evening to > analyze it more thoroughly, and integrate it, if Robert doesn't beat > me. the design seems fine to me. i'll probably (for once) leave the legwork to craig :) (i'm *so* busy catching up right now.) > Some unit tests to exercise the behavior would also be very helpful > :-). +1 BTW i'd be happy for remy to have digester karma - robert --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org