Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 56289 invoked from network); 6 Nov 2003 22:27:56 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 6 Nov 2003 22:27:56 -0000 Received: (qmail 33234 invoked by uid 500); 6 Nov 2003 22:27:38 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 33197 invoked by uid 500); 6 Nov 2003 22:27:38 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 33176 invoked from network); 6 Nov 2003 22:27:38 -0000 Received: from unknown (HELO hume.tsdinc.steitz.com) (209.249.229.10) by daedalus.apache.org with SMTP; 6 Nov 2003 22:27:38 -0000 Content-Class: urn:content-classes:message Received: from Lavoie.tsdinc.steitz.com ([209.249.229.4]) by hume.tsdinc.steitz.com with Microsoft SMTPSVC(5.0.2195.6713); Thu, 6 Nov 2003 17:27:33 -0500 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 Received: from steitz.com ([130.13.97.80]) by Lavoie.tsdinc.steitz.com with Microsoft SMTPSVC(5.0.2195.6713); Thu, 6 Nov 2003 17:27:32 -0500 Message-ID: <3FAACD53.2010200@steitz.com> Date: Thu, 06 Nov 2003 15:38:11 -0700 From: "Phil Steitz" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020830 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Jakarta Commons Developers List" Subject: Re: [collections] [PATCH] CompositeCollection class for Commons-Collections References: <553D9C74-0F9C-11D8-8EA0-000A95782782@forthillcompany.com> <3FA925D7.5040105@steitz.com> <000801c3a401$1d9a9b60$c32b8051@oemcomputer> Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 06 Nov 2003 22:27:33.0042 (UTC) FILETIME=[2BFB2120:01C3A4B5] X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Stephen Colebourne wrote: > From: "Phil Steitz" > >>Anyone have any objections to committing this to the decorators > > subpackage? > >>Phil > > +1. The test needs work as its not a collections-testframework test. I have reworked the test class to extend AbstractTestCollection and have run into a problem. The CompositeCollection interator method returns an IteratorChain.In the test class, I implemented makeCollection to return an empty CompositeCollection. The verifies are failing because IteratorChain.hasNext() throws an UnsupportedOperationException when the chain is empty. So the question is, what (if anything?) should change: a) IteratorChain.hasNext() (return false when the chain is empty) b) CompositeCollection.iterator() (return an emtpy non-chained iterator when the CompsiteCollection is empty) c) No change Thoughts? Phil > > Stephen > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org > For additional commands, e-mail: commons-dev-help@jakarta.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org